Fix incorrect duplicate mock warning. #8167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8167 +/- ##
==========================================
- Coverage 62.29% 62.28% -0.01%
==========================================
Files 265 265
Lines 10433 10434 +1
Branches 2533 2535 +2
==========================================
Hits 6499 6499
Misses 3352 3352
- Partials 582 583 +1
Continue to review full report at Codecov.
|
| beforeEach(() => cleanup(DIR)); | ||
| afterEach(() => cleanup(DIR)); | ||
|
|
||
| test('should not warn when a mock file changes', async () => { |
There was a problem hiding this comment.
I like jest-haste-map tests as e2e tests. The tests in packages/jest-haste-map are really hard on testing internals - this way it's easier to test it behaves properly in a way observable from the outside
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This fixes a regression introduced by: #8153
I've fixed it by using the same logic already present for modules, which also check to be sure the file path isn't a match before warning.
Test plan
I added an e2e test that catches the behavior to ensure this regression will not happen again.
To reproduce manually:
yarn jest packages/jest-haste-map/src/__tests__/index.test.js(or any other test)packages/jest-config/src/__mocks__/fs.jsjest-haste-map: duplicate manual mock found: fsincorrectly shows up