Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plug memory leak in jest-circus when running in band #9934

Merged
merged 3 commits into from
Apr 30, 2020
Merged

fix: plug memory leak in jest-circus when running in band #9934

merged 3 commits into from
Apr 30, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 30, 2020 •
edited
Loading

Summary

I have a fix for this, but I'm hoping CI will tell us it currently leaks, then I can push the fix.

Fixes #8816

Test plan

Activating the leaks checks on circus

@SimenB
Copy link
Member Author

SimenB commented Apr 30, 2020

aight, leaks

image

jeysal
jeysal reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I believe the screenshots you posted on the chat but obviously let's look at CI 😅
One nit that I believe would be nice for clarity, even though we have a test

packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts Outdated

_addSnapshotData(results, snapshotState);

return deepCyclicCopy(results);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say perhaps a comment, and definitely {keepPrototype: false} would be nice to explain this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add suggestion? 😀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50/50 if I get Prettier's brace spacing right 😂

@SimenB
Copy link
Member Author

SimenB commented Apr 30, 2020

image

woo

@codecov-io
Copy link

Codecov Report

Merging #9934 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9934   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files         292      292           
  Lines       12466    12466           
  Branches     3075     3075           
=======================================
  Hits         8007     8007           
  Misses       3810     3810           
  Partials      649      649
Impacted Files Coverage Δ
...circus/src/legacy-code-todo-rewrite/jestAdapter.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1b9dc...d3151ab. Read the comment docs.

@SimenB SimenB changed the title chore: test for memory leak using circus fix: plug memory leak in jest-circus when running in band Apr 30, 2020
jeysal
jeysal approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if everything green

@SimenB
Copy link
Member Author

SimenB commented Apr 30, 2020

node 14 on windows is super flaky, all other is green

@SimenB SimenB merged commit 2fa7f4d into jestjs:master Apr 30, 2020
@SimenB SimenB deleted the circus-leak branch April 30, 2020 15:14
@SimenB SimenB mentioned this pull request May 2, 2020
Merged
@SimenB SimenB mentioned this pull request Jul 2, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jest-circus memory leak
4 participants
@SimenB @codecov-io @jeysal @facebook-github-bot