Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mapCoverage remainings; remove deprecated CLI options test #9968

Merged
merged 6 commits into from
Dec 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
- `[jest-runtime]` [**BREAKING**] Remove deprecated and unnused `getSourceMapInfo` from Runtime ([#9969](https://github.com/facebook/jest/pull/9969))
- `[jest-util]` No longer checking `enumerable` when adding `process.domain` ([#10862](https://github.com/facebook/jest/pull/10862))
- `[jest-validate]` [**BREAKING**] Remove `recursiveBlacklist ` option in favor of previously introduced `recursiveDenylist` ([#10650](https://github.com/facebook/jest/pull/10650))
- `[*]` [**BREAKING**] Remove deprecated `mapCoverage` ([#9968](https://github.com/facebook/jest/pull/9968))

### Performance

Expand Down
25 changes: 0 additions & 25 deletions e2e/__tests__/deprecatedCliOptions.test.ts

This file was deleted.

10 changes: 0 additions & 10 deletions e2e/deprecated-cli-options/__tests__/dummy.js

This file was deleted.

3 changes: 0 additions & 3 deletions e2e/deprecated-cli-options/package.json

This file was deleted.

7 changes: 0 additions & 7 deletions packages/jest-cli/src/cli/args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,6 @@ export const options = {
'node.',
type: 'boolean',
},
mapCoverage: {
default: undefined,
description:
'Maps code coverage reports against original source code ' +
'when transformers supply source maps.\n\nDEPRECATED',
type: 'boolean',
},
maxConcurrency: {
default: 5,
description:
Expand Down
6 changes: 0 additions & 6 deletions packages/jest-config/src/Deprecated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,6 @@ const deprecatedOptions: DeprecatedOptions = {
}
`,

mapCoverage: () => ` Option ${chalk.bold(
'"mapCoverage"',
)} has been removed, as it's no longer necessary.

Please update your configuration.`,

preprocessorIgnorePatterns: (options: {
preprocessorIgnorePatterns?: Array<string>;
}) => ` Option ${chalk.bold(
Expand Down
1 change: 0 additions & 1 deletion packages/jest-config/src/normalize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,6 @@ export default function normalize(
case 'listTests':
case 'logHeapUsage':
case 'maxConcurrency':
case 'mapCoverage':
case 'name':
case 'noStackTrace':
case 'notify':
Expand Down
1 change: 0 additions & 1 deletion packages/jest-types/src/Config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ export type InitialOptions = Partial<{
logHeapUsage: boolean;
lastCommit: boolean;
listTests: boolean;
mapCoverage: boolean;
maxConcurrency: number;
maxWorkers: number | string;
moduleDirectories: Array<string>;
Expand Down
1 change: 0 additions & 1 deletion packages/jest-types/src/Transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@
export type TransformResult = {
code: string;
originalCode: string;
mapCoverage?: boolean; // TODO - Remove in Jest 27
sourceMapPath: string | null;
};