Don't block new PC if connection is stable. #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ym
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
ui/src/routes/devices.$id.tsx:246
- Confirm that increasing the number of reconnection attempts from 5 to 15 aligns with intended network recovery behavior without causing resource exhaustion.
reconnectAttempts: 15,
ui/src/routes/devices.$id.tsx:400
- Ensure that removing the stable connection check does not lead to duplicate active connections; additional cleanup may be required.
if (peerConnection?.signalingState === "stable") {
ui/src/routes/devices.$id.tsx:496
- Verify that the removal of the signalingState argument for sendWebRTCSignal does not affect the intended signaling behavior.
peerConnection?.signalingState,
ym
pushed a commit
that referenced
this pull request
Apr 10, 2025
ym
pushed a commit
to ym/jetkvm-kvm
that referenced
this pull request
Jun 13, 2025
ym
pushed a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the WebRTC signalingState is slow to react, which ends up blocking the recovery of the connection.