refactor: Simplify the management of keyboard layouts #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
force-pushed
the
refactor/keyboard-layouts
branch
3 times, most recently
from
3ea45bb to
dcdb2ab
Compare
|
Resolving merge issues |
IDisposable
force-pushed
the
refactor/keyboard-layouts
branch
from
dcdb2ab to
d19b4b3
Compare
|
Merge issues resolved, sorry about that. |
IDisposable
force-pushed
the
refactor/keyboard-layouts
branch
2 times, most recently
from
d945649 to
9df1bdf
Compare
Add missing keyboard mappings for most layouts Change pasteModel.tsx to use the new structure and vastly clarified the way that keys are emitted. Make each layout export just the KeyboardLayout object (which is a package of isoCode, name, and chars) Made keyboardLayouts.ts export a function to select keyboard by `isoCode`, export the keyboards as label . value pairs (for a select list) and the list of keyboards. Changed devices.$id.settings.keyboard.tsx use the exported keyboard option list.
IDisposable
force-pushed
the
refactor/keyboard-layouts
branch
from
9df1bdf to
a5b07b4
Compare
|
@ym I hope this could be merged soon to fix the paste functiona and random keystrokes |
|
@ym Can you please look into this? |
ym
approved these changes
Jul 11, 2025
adammkelly
pushed a commit
to adammkelly/kvm
that referenced
this pull request
Jul 15, 2025
Add missing keyboard mappings for most layouts Change pasteModel.tsx to use the new structure and vastly clarified the way that keys are emitted. Make each layout export just the KeyboardLayout object (which is a package of isoCode, name, and chars) Made keyboardLayouts.ts export a function to select keyboard by `isoCode`, export the keyboards as label . value pairs (for a select list) and the list of keyboards. Changed devices.$id.settings.keyboard.tsx use the exported keyboard option list.
adammkelly
pushed a commit
to adammkelly/kvm
that referenced
this pull request
Jul 15, 2025
Add missing keyboard mappings for most layouts Change pasteModel.tsx to use the new structure and vastly clarified the way that keys are emitted. Make each layout export just the KeyboardLayout object (which is a package of isoCode, name, and chars) Made keyboardLayouts.ts export a function to select keyboard by `isoCode`, export the keyboards as label . value pairs (for a select list) and the list of keyboards. Changed devices.$id.settings.keyboard.tsx use the exported keyboard option list.
ym
pushed a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
Add missing keyboard mappings for most layouts Change pasteModel.tsx to use the new structure and vastly clarified the way that keys are emitted. Make each layout export just the KeyboardLayout object (which is a package of isoCode, name, and chars) Made keyboardLayouts.ts export a function to select keyboard by `isoCode`, export the keyboards as label . value pairs (for a select list) and the list of keyboards. Changed devices.$id.settings.keyboard.tsx use the exported keyboard option list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the paste modal code.
Make it so you just add one line for a new keyboard layout and update the list of keyboards.
Made each layout have it's isoCode and name bundled with the paste characters map.