-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a disconnected login flow #55
Conversation
Fixes #54. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Thanks Charlie! Have you tested it?
I then tried entering the (sorry for the mega image, just wanted to show the URL as well) |
Also, might be good to allow a user to Ctrl-C out of the command whilst it's hanging waiting for user input, perhaps a matter of passing in context, I've not looked at the code yet. |
I have tested this and it does work. The URL to enter is the localhost9999 one after the redirect completes. The server isn't running so the connection_refused error is expected. I tried to explain this in the message:
I do however need to make sure that ctrl+C works so I'll do that now. |
I have added the interrupt in 98b1cf9 |
Cool I think I have misunderstood it, I assumed that the use case is enterprise VPN setup where folks might not be able to access Jetstack Secure and their cluster from the same machine. What is the use case then and how can this PR be tested? |
This can be tested on a normal machine / env. First, run:
Visit the URL on any device. Phone or even the same machine. Copy the localhost:9999 URL into the terminal window. Press enter. Verify that you are logged in. |
waiting for feedback on #50 (comment) before merging |
We've had some acknowledgment that this ought to work ok now. @irbekrm can you ✅ ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Charlie
/lgtm
Thanks Irbe. |
Fixes #50.
Test this with:
Signed-off-by: Charlie Egan charlieegan3@users.noreply.github.com