Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
jetty · Jan 12, 2024 · d724208 · d724208
1 parent b19dc8a
commit d724208
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...re/jetty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Session.java b/...re/jetty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Session.java
@@ -1935,7 +1935,7 @@ private boolean onIdleTimeout()
                         goAwayFrame = goAwaySent;
                         closed = CloseState.CLOSING;
                         zeroStreamsAction = null;
-                        failure = cause = new TimeoutException("Session idle timeout expired");
+                        failure = cause = newTimeoutException();
                     }
                     case REMOTELY_CLOSED ->
                     {
@@ -1944,7 +1944,7 @@ private boolean onIdleTimeout()
                         goAwayFrame = goAwaySent;
                         closed = CloseState.CLOSING;
                         zeroStreamsAction = null;
-                        failure = cause = new TimeoutException("Session idle timeout expired");
+                        failure = cause = newTimeoutException();
                     }
                     default -> terminate = true;
                 }
@@ -1955,7 +1955,7 @@ private boolean onIdleTimeout()
                 if (LOG.isDebugEnabled())
                     LOG.debug("Already closed, ignored idle timeout for {}", HTTP2Session.this);
                 // Writes may be TCP congested, so termination never happened.
-                flusher.abort(new TimeoutException());
+                flusher.abort(newTimeoutException());
                 return false;
             }
 
@@ -1977,6 +1977,11 @@ private boolean onIdleTimeout()
             return false;
         }
 
+        private TimeoutException newTimeoutException()
+        {
+            return new TimeoutException("Session idle timeout expired");
+        }
+
         private void onSessionFailure(int error, String reason, Callback callback)
         {
             GoAwayFrame goAwayFrame;