Fixes #11259 - HTTP/2 connection not closed after idle timeout when TCP congested. #11267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CP congested. Now upon the second idle timeout, the connection is forcibly closed. Fixed also similar problem in HTTP/3. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
Jan 12, 2024
| if (LOG.isDebugEnabled()) | ||
| LOG.debug("Already closed, ignored idle timeout for {}", HTTP2Session.this); | ||
| // Writes may be TCP congested, so termination never happened. | ||
| flusher.abort(new TimeoutException()); |
There was a problem hiding this comment.
All branches of the switch above result in a new TimeoutException, so just do it once before the switch
There was a problem hiding this comment.
Uhm, no. The TimeoutException is only allocated if terminate=true which only happens if the session is already in CLOSED state.
There was a problem hiding this comment.
It is also allocated in locally and remotely closed cases. At least give it the same message as the others.
lorban
previously approved these changes
Jan 12, 2024
gregw
requested changes
Jan 12, 2024
| if (LOG.isDebugEnabled()) | ||
| LOG.debug("Already closed, ignored idle timeout for {}", HTTP2Session.this); | ||
| // Writes may be TCP congested, so termination never happened. | ||
| flusher.abort(new TimeoutException()); |
There was a problem hiding this comment.
It is also allocated in locally and remotely closed cases. At least give it the same message as the others.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
Jan 12, 2024
sbordet
added a commit
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now upon the second idle timeout, the connection is forcibly closed.
Fixed also similar problem in HTTP/3.