diff --git a/extensions/omniv21/samples/edi/1_canadapost_edi_214.schema.json b/extensions/omniv21/samples/edi/1_canadapost_edi_214.schema.json index 820f457..7f4b592 100644 --- a/extensions/omniv21/samples/edi/1_canadapost_edi_214.schema.json +++ b/extensions/omniv21/samples/edi/1_canadapost_edi_214.schema.json @@ -12,6 +12,7 @@ "child_segments": [ { "name": "GS", + "_comment": "functional group", "child_segments": [ { "name": "scanInfo", "type": "segment_group", "min": 0, "max": -1, "is_target": true, @@ -26,7 +27,7 @@ { "name": "N4", "elements": [ - { "name": "cityName", "index": 1 }, + { "name": "cityName", "index": 1, "_comment": "E19" }, { "name": "provinceCode", "index": 2 }, { "name": "postalCode", "index": 3 }, { "name": "countryCode", "index": 4 } diff --git a/extensions/omniv21/samples/edi/2_ups_edi_210.schema.json b/extensions/omniv21/samples/edi/2_ups_edi_210.schema.json index 11e8c7d..e6ce9b3 100644 --- a/extensions/omniv21/samples/edi/2_ups_edi_210.schema.json +++ b/extensions/omniv21/samples/edi/2_ups_edi_210.schema.json @@ -14,6 +14,7 @@ "child_segments": [ { "name": "GS", + "_comment": "functional group", "child_segments": [ { "name": "invoiceInfo", "type": "segment_group", "min": 0, "max": -1, "is_target": true, @@ -74,7 +75,7 @@ "elements": [ { "name": "refIdQualifier_N901", "index": 1 }, { "name": "refId_N902", "index": 2, "default": "" }, - { "name": "date", "index": 4, "default": "" }, + { "name": "date", "index": 4, "default": "", "_comment": "YYYYMMDD"}, { "name": "product_code_C04004", "index": 7, "component_index": 4, "default": "" } ] }, diff --git a/extensions/omniv21/validation/ediFileDeclaration.go b/extensions/omniv21/validation/ediFileDeclaration.go index bf65a8c..c93f8f3 100644 --- a/extensions/omniv21/validation/ediFileDeclaration.go +++ b/extensions/omniv21/validation/ediFileDeclaration.go @@ -49,7 +49,8 @@ const ( "index": { "type": "integer", "minimum": 1 }, "component_index": { "type": "integer", "minimum": 1 }, "empty_if_missing": { "type": "boolean","$comment": "deprecated, use 'default'" }, - "default": { "type": "string" } + "default": { "type": "string" }, + "_comment": { "$ref": "#/definitions/value_comment" } }, "required": [ "name", "index" ], "additionalProperties": false @@ -60,11 +61,13 @@ const ( "items": { "$ref": "#/definitions/segment_declaration_type" } - } + }, + "_comment": { "$ref": "#/definitions/value_comment" } }, "required": [ "name" ], "additionalProperties": false - } + }, + "value_comment": { "type": "string" } } } ` diff --git a/extensions/omniv21/validation/ediFileDeclaration.json b/extensions/omniv21/validation/ediFileDeclaration.json index e5d4db4..2a30335 100644 --- a/extensions/omniv21/validation/ediFileDeclaration.json +++ b/extensions/omniv21/validation/ediFileDeclaration.json @@ -42,7 +42,8 @@ "index": { "type": "integer", "minimum": 1 }, "component_index": { "type": "integer", "minimum": 1 }, "empty_if_missing": { "type": "boolean","$comment": "deprecated, use 'default'" }, - "default": { "type": "string" } + "default": { "type": "string" }, + "_comment": { "$ref": "#/definitions/value_comment" } }, "required": [ "name", "index" ], "additionalProperties": false @@ -53,10 +54,12 @@ "items": { "$ref": "#/definitions/segment_declaration_type" } - } + }, + "_comment": { "$ref": "#/definitions/value_comment" } }, "required": [ "name" ], "additionalProperties": false - } + }, + "value_comment": { "type": "string" } } } \ No newline at end of file