-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flask 1.0.2 compatibility #692
base: master
Are you sure you want to change the base?
Conversation
This works for me with Flask 1.0.2 and Python 3.6.5. Can this be merged? |
Don';t really want to +1, but +1. The examples in the documentation don't even work without this patch. |
I think that similar fix should be applied to eval |
this will be merged? |
@jfinkels are you still maintaining this library? |
No, sorry. I'm afraid I don't have time for it.
…On Sat, Mar 28, 2020 at 6:29 PM Stephen Holsapple ***@***.***> wrote:
@jfinkels <https://github.com/jfinkels> are you still maintaining this
library?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#692 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5XG2B7ELSFR3T3VBCIF3RJZ237ANCNFSM4GDC6NHQ>
.
|
That's sad to hear. It was a great library. Thanks for building it and maintaining it over the years. :) Can you mark the library as deprecated somehow? Stuff like that talked about in https://medium.com/maintainer-io/how-to-deprecate-a-repository-on-github-8f0ceb9155e sounds like a decent approach, and similar to what others have been doing. |
I've left a notice in the GitHub description and the README that I am no
longer maintaining this repository. Thanks for the suggestion, and sorry
for the inconvenience.
…On Mon, Apr 6, 2020 at 12:27 PM Stephen Holsapple ***@***.***> wrote:
That's sad to hear. It was a great library. Thanks for building it and
maintaining it over the years. :)
Can you mark the library as deprecated somehow? Stuff like that talked
about in
https://medium.com/maintainer-io/how-to-deprecate-a-repository-on-github-8f0ceb9155e
sounds like a decent approach, and similar to what others have been doing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#692 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5XGZUG7YE3I73SPHK2DDRLH7GDANCNFSM4GDC6NHQ>
.
|
Hi, there is a fork project Flask-Restless-NG that has this issue and some other issues fixed, along with performance improvements |
Flask 1.0.2
doesn't allow dots in Blueprint view functions since commit pallets/flask@2f57a0bAs there are some view function names ended with
.relationship
,Flask-Restless
breaks recent versions ofFlask
. I have changed this names and now they ends with_relationship
. It seems to work withFlask 1.0.2
.This solves #686.