diff --git a/CHANGELOG.md b/CHANGELOG.md index 7b2607eed4e..927fbf2f90d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,18 @@ # Changelog +## 23.10.4 + +### Breaking Changes + +### Deprecations +- Forest pruning (`pruning-enabled` options) is deprecated and will be removed soon. To save disk space consider switching to Bonsai data storage format [#6230](https://github.com/hyperledger/besu/pull/6230) + +### Additions and Improvements +- Add error messages on authentication failures with username and password [#6212](https://github.com/hyperledger/besu/pull/6212) + +### Bug fixes + + ## 23.10.3 ### Breaking Changes diff --git a/besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java b/besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java index 91ef840d62e..a4045cee1c5 100644 --- a/besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java +++ b/besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java @@ -2059,6 +2059,11 @@ private void issueOptionWarnings() { "--privacy-onchain-groups-enabled", "--privacy-flexible-groups-enabled"); } + + if (isPruningEnabled()) { + logger.warn( + "Forest pruning is deprecated and will be removed soon. To save disk space consider switching to Bonsai data storage format."); + } } private void configure() throws Exception { diff --git a/besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java b/besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java index 85586871483..0df397af71f 100644 --- a/besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java +++ b/besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java @@ -3815,6 +3815,21 @@ public void pruningParametersAreCaptured() throws Exception { assertThat(pruningArg.getValue().getBlockConfirmations()).isEqualTo(4); } + @Test + public void pruningLogsDeprecationWarning() { + parseCommand("--pruning-enabled"); + + verify(mockControllerBuilder).isPruningEnabled(true); + + assertThat(commandOutput.toString(UTF_8)).isEmpty(); + assertThat(commandErrorOutput.toString(UTF_8)).isEmpty(); + verify(mockLogger) + .warn( + contains( + "Forest pruning is deprecated and will be removed soon." + + " To save disk space consider switching to Bonsai data storage format.")); + } + @Test public void devModeOptionMustBeUsed() throws Exception { parseCommand("--network", "dev");