Fix data races in stream.state #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a way for an application to receive volume change notifications when the volume changes (either through SetVolume or because it was changed in the system mixer settings).
PlaybackStream and RecordStream had both a 'state' variable that got read and updated from different goroutines. This is a data race, and shows up when running with the -race flag. I've tried to make the code a bit less racy, and used an atomic value to fix the warnings about the race condition. I'm still not 100% convinced this fixes all races though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlaybackStream and RecordStream had both a 'state' variable that got read and updated from different goroutines. This is a data race, and shows up when running with the -race flag.
I've tried to make the code a bit less racy, and used an atomic value to fix the warnings about the race condition. I'm still not 100% convinced this fixes all races though.
(Draft, because it conflicts with #35. I'll rebase once that PR gets merged or closed).