From f16bcabce5aec5a7b4cbd57f9f43d945c83fb960 Mon Sep 17 00:00:00 2001 From: "J. Frimmel" <31166235+jfrimmel@users.noreply.github.com> Date: Sun, 22 May 2022 09:03:33 +0200 Subject: [PATCH] Temorarily delete Clippy in CI It seems like the current approach of commenting clippy issues isn't working, if someone forks a repository and triggers a pull request from there (see https://github.com/actions/first-interaction/issues/10). Since the clippy output contains only messages, that are nice-to-have, but non-essential, this commit simply disables the whole action in CI. This should be looked at and fixed later on. --- .github/workflows/clippy.yaml | 32 -------------------------------- 1 file changed, 32 deletions(-) delete mode 100644 .github/workflows/clippy.yaml diff --git a/.github/workflows/clippy.yaml b/.github/workflows/clippy.yaml deleted file mode 100644 index 1b8cffd..0000000 --- a/.github/workflows/clippy.yaml +++ /dev/null @@ -1,32 +0,0 @@ -name: Linting -on: pull_request -defaults: - run: - shell: bash -jobs: - clippy: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - run: rustup update nightly && rustup default nightly - - run: rustup component add clippy-preview - - name: Run clippy lints - id: clippy - run: | - echo '# Output of `cargo clippy`' > clippy.output - echo '```' >> clippy.output - # ignore dependency output lines - cargo clippy 2>&1 | sed -n '/Checking cargo-valgrind v.*/,$p' | tee -a clippy.output || true - echo '```' >> clippy.output - echo 'If your PR introduced these issues, please try to address them.' >> clippy.output - # the clippy exit code is ignored, therefore the build always works - echo "::set-output name=line_count::$(wc -l clippy.output | cut -f 1 -d ' ')" - - run: echo '${{ steps.clippy.outputs.line_count }}' - - run: wc -l clippy.output | cut -f 1 -d ' ' - - name: Comment clippy output - if: ${{ steps.clippy.outputs.line_count > 6 }} - uses: machine-learning-apps/pr-comment@1.0.0 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - path: clippy.output