When using foreach, the keyset method loops infinitely

[bigzibo]

code
public static void main(String[] args) { ExpiringMap<String, String> map = ExpiringMap.builder() .maxSize(100) .expiration(20L, TimeUnit.MINUTES) .expirationPolicy(ExpirationPolicy.ACCESSED) .variableExpiration() .build(); map.put("1", "1"); map.put("2", "2"); map.keySet().forEach((key) -> { System.out.println(map.get(key)); }); }

and result
1 2 1 2 1 2 1 2 .....

[bigzibo]

    <dependency>
        <groupId>net.jodah</groupId>
        <artifactId>expiringmap</artifactId>
        <version>0.5.9</version>
    </dependency>

[jhalterman]

Happy to take a PR for this.

[r0b0ji]

There is something wrong when ExpirationPolicy is ACCESSED. For ex:

This works.

 @Test
  public void testLoopTerminates() {
    ExpiringMap<String, String> map = ExpiringMap.builder()
            .maxSize(100)
            .expiration(20L, TimeUnit.MINUTES)
            .expirationPolicy(ExpirationPolicy.CREATED)
            .variableExpiration()
            .build();

    map.put("1", "1");
    map.put("2", "2");

    map.keySet().forEach(key -> System.out.println(map.get(key)));
  }

But this doesn't.

@Test
  public void testLoop() {
    ExpiringMap<String, String> map = ExpiringMap.builder()
            .maxSize(100)
            .expiration(20L, TimeUnit.MINUTES)
            .expirationPolicy(ExpirationPolicy.ACCESSED)
            .variableExpiration()
            .build();

    map.put("1", "1");
    map.put("2", "2");

    map.keySet().forEach(key -> System.out.println(map.get(key)));
  }

[r0b0ji]

This is a bug.

[r0b0ji]

The bug is that get > resetEntry (if policy is accessed) > reorder (removes and add)

This looks like a bug, that it adds again, so when I removed the reorder line, it worked fine but then I am not sure if that is correct fix.