Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BrowserKit with Guzzle client #628

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

claudiu-cristea
Copy link
Contributor

@claudiu-cristea claudiu-cristea commented Nov 16, 2022

Problem

Proving the bug

I've created a "test only" PR #627

Proposal

Use Drupal\Tests\DrupalTestBrowser as BrowserKitDriver client. This also has the advantage that is aligned with Drupal core PHPUnit tests.

@jhedstrom jhedstrom merged commit af159e0 into jhedstrom:master Nov 18, 2022
@jhedstrom
Copy link
Owner

This looks great, thanks!

@pfrenssen pfrenssen mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants