Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip about ARM64 when generating Docker Compose files #21247

Merged
merged 7 commits into from
Feb 28, 2023
Merged

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Feb 27, 2023

Fixes an issue I've had in demos when I copy the command verbatim on my M1.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mraible mraible requested a review from mshima February 28, 2023 04:04
@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

I'm not sure why snapshots were deleted when I ran npm run update-snapshots.

@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

If I restore the snapshots and run npm test with these changes, I get 73 test failures and it takes time: 13 min. 29 s. This duration seems excessive. I'm using Node.js v18.14.0.

@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

I tried running npm test on the main branch and I get similar results: 74 failures in 13 min. 27 s.

@mshima mshima merged commit 3d09c4b into main Feb 28, 2023
@mshima mshima deleted the docker-arm64-tip branch February 28, 2023 13:52
@mshima
Copy link
Member

mshima commented Feb 28, 2023

Merged without finishing the build 😕 . I thought it wasn’t possible .

@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

@mshima Do you know why npm test doesn't pass locally? I tried using Node 16.19.0 and it seems much faster, but still fails.

  7861 passing (1m)
  317 pending
  1 failing

  1) Uncaught error outside test suite:
     Uncaught Workerpool Worker terminated Unexpectedly
    exitCode: `1`
    signalCode: `null`
    workerpool.script: `/Users/mraible/dev/generator-jhipster/node_modules/mocha/lib/nodejs/worker.js`
    spawnArgs: `/Users/mraible/.nvm/versions/node/v16.19.0/bin/node,--loader=file:///Users/mraible/dev/generator-jhipster/node_modules/@node-loaders/auto/dist/index-strict.js,/Users/mraible/dev/generator-jhipster/node_modules/mocha/lib/nodejs/worker.js`
    spawnfile: `/Users/mraible/.nvm/versions/node/v16.19.0/bin/node`
    stdout: `null`
    stderr: `null`

@mshima
Copy link
Member

mshima commented Feb 28, 2023

I tried running npm test on the main branch and I get similar results: 74 failures in 13 min. 27 s.

It should take less than 3min. I will try.

@mshima
Copy link
Member

mshima commented Feb 28, 2023

@mraible try to remove node_modules. And run npm ci.

@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

Removing node_modules and running npm ci results in one error:

  7876 passing (1m)
  323 pending
  1 failing

  1) jdl - JDLImporter
       import
         when passing the skipFileGeneration option
           should not create the .jhipster folder:

      /Users/mraible/dev/generator-jhipster/test/jdl/jdl-importer.spec.ts:803
        expect(fse.existsSync('.jhipster')).to.be.false;
                                               ^

AssertionError: expected true to be false
      + expected - actual

      -true
      +false

      at Context.<anonymous> (test/jdl/jdl-importer.spec.ts:803:48)
      at processImmediate (node:internal/timers:466:21)

I ran npm run build to try and fix. I get the same Uncaught Workerpool Worker terminated Unexpectedly error.

@mshima
Copy link
Member

mshima commented Feb 28, 2023

Node 18 support looks broken at main

@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

Yeah, with Node 18, the tests still take forever. I see a lot of "applying multi-step templates" messages.

Screenshot 2023-02-28 at 7 56 50 AM

@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2023

I just tested this issue with Node 16 and it doesn't happen. It seems to be a Node 18 issue.

@mshima
Copy link
Member

mshima commented Mar 2, 2023

@mraible tried with 18.13.0 and it works.

@mraible
Copy link
Contributor Author

mraible commented Mar 8, 2023

@mshima Maybe it's a problem with v18.14.0? That's what I'm using and it stops before installing anything when I run jhipster jdl reactive-mf.

Screenshot 2023-03-08 at 12 06 34 PM

Since 18.15.0 is the latest LTS (according to https://nodejs.org), I tried that too. I get the same result.

I tried with Node.js 18.13.0 and it seems to work fine.

@mshima
Copy link
Member

mshima commented Mar 8, 2023

I thought I had said it was broken on 18.14.0 and 18.14.1.
It’s indeed broken on node >=18.14.0.

@mshima
Copy link
Member

mshima commented Mar 8, 2023

@mraible looks related to nodejs/node#46595.
Backport 18.x is pending.
We probably should blacklist 18.14.x and 18.15.0

@mshima mshima mentioned this pull request Mar 11, 2023
1 task
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants