From 8fe62d2e04ee24b7f03f266765be3cca85061b43 Mon Sep 17 00:00:00 2001 From: jimmyday12 Date: Fri, 6 Dec 2019 12:45:07 +1100 Subject: [PATCH] Prevents vignette from running if the cookie fails --- NEWS.md | 3 +++ vignettes/womens-stats.Rmd | 28 ++++++++++++++++++++-------- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/NEWS.md b/NEWS.md index 6775030b..b4c2a7b3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,8 @@ # fitzRoy 0.2.0.9000 +## Features +* Updated `womens-stats` vignette to prevent it from running chunks if the cookie had failed. + ## Breaking changes * Addition of `replace_venues` - changes venue names for all data sources to match AFL Tables ([#15](https://github.com/jimmyday12/fitzRoy/issues/15), [@cfranklin11](https://github.com/cfranklin11)) diff --git a/vignettes/womens-stats.Rmd b/vignettes/womens-stats.Rmd index 972a8bdb..fe2b769e 100644 --- a/vignettes/womens-stats.Rmd +++ b/vignettes/womens-stats.Rmd @@ -15,10 +15,6 @@ knitr::opts_chunk$set( comment = "#>" ) ``` -```{r gh-installation, eval = FALSE, echo = TRUE} -# install.packages("devtools") -# devtools::install_github("jimmyday12/fitzRoy") -``` ### Match data @@ -27,10 +23,26 @@ library(fitzRoy) library(dplyr) ``` +A good thing to check is that the cookie is working. Often this gets changed or moved and without it, the code won't work. + +```{r cookie, message = FALSE, warning = FALSE} +cookie <- get_aflw_cookie() + +print(cookie) +``` +Note - if this is `NULL` the rest of this Vignette won't show any outputs but the code will remain! + +```{r cookie_param, include=FALSE} +if (is.null(cookie)) { + eval_param = FALSE + } + +``` + We can use the `get_aflw_match_data()` function to retrieve match data for all matches. -```{r fetch_match_stats, message=FALSE, warning=TRUE,} +```{r fetch_match_stats, message=FALSE, warning=TRUE, eval = eval_param} match_data <- get_aflw_match_data() ``` @@ -38,7 +50,7 @@ Note that there will be warnings if a fixture is available but no match data has been added yet. If this is the case, make sure you don't try to request detailed match stats for these match IDs. -```{r show_match_stats, message=FALSE, warning=FALSE} +```{r show_match_stats, message=FALSE, warning=FALSE, eval = eval_param} glimpse(match_data) ``` @@ -49,13 +61,13 @@ match data shown above. It takes a vector of match IDs as an argument. For example, let's say we want detailed stats for the first 10 games in `match_data` above. Then we would do: -```{r first_10, message=FALSE, warning=FALSE} +```{r first_10, message=FALSE, warning=FALSE, eval = eval_param} first10 <- head(match_data, 10) first10_ids <- first10$Match.Id first10_ids ``` -```{r} +```{r, eval = eval_param} detailed <- get_aflw_detailed_data(first10_ids) glimpse(detailed) ```