Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ladder function #85

Closed
jimmyday12 opened this issue Oct 1, 2019 · 4 comments
Closed

Add Ladder function #85

jimmyday12 opened this issue Oct 1, 2019 · 4 comments
Labels
feature a feature request or enhancement

Comments

@jimmyday12
Copy link
Owner

There should be an easy function to return the AFL ladder for any round. The Squiggle API does a decent job back to round 2011

@jimmyday12 jimmyday12 added the feature a feature request or enhancement label Oct 14, 2019
@JaseZiv
Copy link
Contributor

JaseZiv commented Dec 4, 2019

I have a function that might do this... it takes in a data frame obtained using get_match_results() and can return results from all regular season rounds and all seasons, or be limited to certain round(s) and season(s).

Any interest in this?

@jimmyday12
Copy link
Owner Author

@JaseZiv Yep certainly some interest. My initial thoughts were just writing a scraper but your approach could be feasible too and possibly faster since get_match_results() is relatively quick to scrape.

@JaseZiv
Copy link
Contributor

JaseZiv commented Dec 4, 2019

@jimmyday12 Ok great. I've got the function ready so I'll write some docs and create a pull request tomorrow hopefully and you can let me know your thoughts.

@jimmyday12
Copy link
Owner Author

Fixed by 45d7b0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants