Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created function to return ladder #94

Merged
merged 4 commits into from
Dec 9, 2019
Merged

created function to return ladder #94

merged 4 commits into from
Dec 9, 2019

Conversation

JaseZiv
Copy link
Contributor

@JaseZiv JaseZiv commented Dec 5, 2019

Addressing issue #85

@jimmyday12
Copy link
Owner

@JaseZiv - so I've made a commit (8fe62d2) that fixes the womens-stats error on Travis. If you merge master into your PR and resubmit it should be fine.

Also, just to note, to get tests to run on your local machine properly you have to do the following code since we are using skip_on_cran() in our tests.

Sys.setenv(NOT_CRAN = "true")
devtools::check()

Related to this issue that should be fixed soon in devtools

JaseZiv and others added 2 commits December 6, 2019 22:01
Prevents vignette from running if the cookie fails
git commit -m "merge master for fix on the womens-stats error on Travis"
@JaseZiv
Copy link
Contributor Author

JaseZiv commented Dec 6, 2019

@jimmyday12 Great stuff. Thanks for the heads up. Hope the function is of help.

@jimmyday12 jimmyday12 merged commit 45d7b0d into jimmyday12:master Dec 9, 2019
@JaseZiv JaseZiv deleted the ladder branch December 9, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants