-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Dark Theme" CSS (Incomplete) #187
base: master
Are you sure you want to change the base?
Conversation
If this really works and stops the white page flashing when I open up my new tab, I'd love to have this in the extension. I tried opening up my localdata folder and copying in the CSS myself, but Chrome recognized that it "corrupted" the extension (probably changed the hash and set off flares for security purposes). Any way I could get this change on my local install of the app? Thanks! |
@lucasrumney94 The way I did this for myself was to fork the repo, make the changes in this PR, and then enable "developer mode" on the extensions tab to get an option to load my "unpacked extension". I also turned off the official one. Hopefully some combination of these steps lets you use the modifications as well in the mean time. |
Great Extension, Great Fix@alainbryden Hopefully this change gets pulled into master and/or helps the next person looking for this. Personally, I believe that having a dark interstitial screen by default is the less aggressive of the two options, especially for night-time users of the internet. Thanks again and have a great week! BeforeAfterEDIT: I can't post art this without attribution, the artist is Maciej Kuciara. |
@alainbryden |
This proposal is fantastic, and I would love to see it merged into the master branch. It would be even better if there's an option to specify a background color. I often work late at night, and the sudden white flash is quite bothersome. Fast New Tab Redirect helps solve this issue, but it's using manifest v2, and when I open a new window from a closed Chrome instance, it still displays a blank, meaningless screen. Therefore, I would love to see NewTab-Redirect support dark mode! |
To get the conversation started on #175, these are some minimal changes I've made to the CSS to get everything looking "nice", but in a dark theme (based on the colour scheme of other well-accepted dark themes).
I realize that the more difficult job is to make this configurable / togglable, so my apologies for not delving into that myself.
The most important aspect of this change is that when opening a new tab (in the few milliseconds before the redirect), the user does not get greeted with a flash of white before then transitioning to a dark destination site.
If you wanted to be real smooth, you could actually "remember" the body background-colour of the configured redirect site, and set that as the background, but I have no thoughts on you could implement that - just an idea.
All the best,