-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong transcription order #520
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
============================================
+ Coverage 20.86% 21.85% +0.99%
- Complexity 289 309 +20
============================================
Files 74 76 +2
Lines 6222 6269 +47
Branches 833 838 +5
============================================
+ Hits 1298 1370 +72
+ Misses 4699 4671 -28
- Partials 225 228 +3
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the imports to be star imports.
Please avoid making style changes in the same commit with some fixes as it make it impossible for review, so can you isolate the fix in separate commit?
About the style of the java code all existing code follow
https://desktop.jitsi.org/Documentation/CodeConvention.html
And we tried to enforce it with the checkstyle.
The receiving timestamp will be sent to skynet to be used as absolute timestamp for the audio chunk - the network lag is presumed to be less than tens of milliseconds (a latency of 20-50 ms is expected and it is considered to be ok as loss of time).