From 88513f33258833add6837233022307147ff06fd2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Thu, 23 Apr 2020 18:05:30 -0400 Subject: [PATCH 1/2] spelling: manager --- src/main/java/org/jitsi/videobridge/Endpoint.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jitsi/videobridge/Endpoint.java b/src/main/java/org/jitsi/videobridge/Endpoint.java index 1b97c0a1fe..c6ac7cf112 100644 --- a/src/main/java/org/jitsi/videobridge/Endpoint.java +++ b/src/main/java/org/jitsi/videobridge/Endpoint.java @@ -855,7 +855,7 @@ private void updateStatsOnExpire() */ public void createSctpConnection() { - logger.debug(() -> "Creating SCTP mananger"); + logger.debug(() -> "Creating SCTP manager"); // Create the SctpManager and provide it a method for sending SCTP data this.sctpManager = new SctpManager( (data, offset, length) -> { From e26301eab0a15f2366f5d2b73e2c0cc714007a14 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 22 Mar 2020 18:38:06 -0400 Subject: [PATCH 2/2] Add check-spelling --- .github/actions/spell-check/advice.txt | 16 + .github/actions/spell-check/excludes.txt | 57 +++ .../actions/spell-check/patterns/README.md | 12 + .../actions/spell-check/patterns/domain.txt | 6 + .../actions/spell-check/patterns/patterns.txt | 26 ++ .../actions/spell-check/whitelist/README.md | 9 + .../actions/spell-check/whitelist/debian.txt | 47 ++ .../actions/spell-check/whitelist/jitsi.txt | 408 ++++++++++++++++++ .../actions/spell-check/whitelist/names.txt | 40 ++ .../spell-check/whitelist/pom-version.txt | 4 + .../actions/spell-check/whitelist/systemd.txt | 19 + .../spell-check/whitelist/whitelist.txt | 1 + .github/workflows/spelling.yml | 21 + 13 files changed, 666 insertions(+) create mode 100644 .github/actions/spell-check/advice.txt create mode 100644 .github/actions/spell-check/excludes.txt create mode 100644 .github/actions/spell-check/patterns/README.md create mode 100644 .github/actions/spell-check/patterns/domain.txt create mode 100644 .github/actions/spell-check/patterns/patterns.txt create mode 100644 .github/actions/spell-check/whitelist/README.md create mode 100644 .github/actions/spell-check/whitelist/debian.txt create mode 100644 .github/actions/spell-check/whitelist/jitsi.txt create mode 100644 .github/actions/spell-check/whitelist/names.txt create mode 100644 .github/actions/spell-check/whitelist/pom-version.txt create mode 100644 .github/actions/spell-check/whitelist/systemd.txt create mode 100644 .github/actions/spell-check/whitelist/whitelist.txt create mode 100644 .github/workflows/spelling.yml diff --git a/.github/actions/spell-check/advice.txt b/.github/actions/spell-check/advice.txt new file mode 100644 index 0000000000..a7c6558f54 --- /dev/null +++ b/.github/actions/spell-check/advice.txt @@ -0,0 +1,16 @@ +
+ +:pencil2: Contributor please read this + + +* If the items listed above are names, please add them to `.github/actions/spell-check/dictionary/names.txt`. +* You can probably just add items into `.github/actions/spell-check/whitelist/jitsi.txt`. +* If you need to use a specific token in one place and it shouldn't generally be used, you can +add an item in `.github/actions/spell-check/patterns.txt`. + +See the `README.md` in each directory for more information. +
+ +#### :warning: Reviewers +At present, the action that triggered this message will not show its :x: in this PR unless the branch is within this repository. +Thus, you **should** make sure that this comment has been addressed before merging this PR. diff --git a/.github/actions/spell-check/excludes.txt b/.github/actions/spell-check/excludes.txt new file mode 100644 index 0000000000..11a51fb97c --- /dev/null +++ b/.github/actions/spell-check/excludes.txt @@ -0,0 +1,57 @@ +(?:^|/)dirs$ +(?:^|/)go\.mod$ +(?:^|/)go\.sum$ +(?:^|/)package-lock\.json$ +(?:^|/)sources(?:|\.dep)$ +SUMS$ +\.ai$ +\.bmp$ +\.cer$ +\.class$ +\.crl$ +\.crt$ +\.csr$ +\.dll$ +\.DS_Store$ +\.eot$ +\.eps$ +\.exe$ +\.gif$ +\.graffle$ +\.gz$ +\.icns$ +\.ico$ +\.jar$ +\.jpeg$ +\.jpg$ +\.key$ +\.lib$ +\.lock$ +\.map$ +\.min\.. +\.mp3$ +\.mp4$ +\.otf$ +\.pbxproj$ +\.pdf$ +\.pem$ +\.png$ +\.pom$ +\.psd$ +\.runsettings$ +\.sig$ +\.so$ +\.svg$ +\.svgz$ +\.tar$ +\.tgz$ +\.ttf$ +\.woff +\.xcf$ +\.xls +\.xpm$ +\.yml$ +\.zip$ +^\.editorconfig$ +^\.github/actions/spell-check/ +^\.gitignore$ diff --git a/.github/actions/spell-check/patterns/README.md b/.github/actions/spell-check/patterns/README.md new file mode 100644 index 0000000000..641f390eef --- /dev/null +++ b/.github/actions/spell-check/patterns/README.md @@ -0,0 +1,12 @@ +The contents of each `.txt` file in this directory are merged together. +Each line is a Perl 5 regular expression. +Nothing is guaranteed about the order in which they're merged. +-- If this is a problem, please reach out. + +Note: order of the contents of these files can matter. +Lines from an individual file are handled in file order. +Files are selected in alphabetical order. + +* [patterns](patterns.txt) is the main list -- there is nothing +particularly special about the file name (beyond the extension which is +important). diff --git a/.github/actions/spell-check/patterns/domain.txt b/.github/actions/spell-check/patterns/domain.txt new file mode 100644 index 0000000000..cf62cc8402 --- /dev/null +++ b/.github/actions/spell-check/patterns/domain.txt @@ -0,0 +1,6 @@ +# These are violations of TLD namespace +# They should use example.com and friends +# This file is here to shame the project into fixing things + +fdfsgv1\@auth\.domain23\.com/pc3 +focus@auth\.domain4?\.com/fdsfwetg diff --git a/.github/actions/spell-check/patterns/patterns.txt b/.github/actions/spell-check/patterns/patterns.txt new file mode 100644 index 0000000000..7a8da194ee --- /dev/null +++ b/.github/actions/spell-check/patterns/patterns.txt @@ -0,0 +1,26 @@ +https://(?:(?:www\.|)youtube\.com|youtu.be)/[-a-zA-Z0-9?&=]* +https://groups\.google\.com/d/topic/[^/]+/[a-zA-Z0-9]+/discussion +-D(?:java|net|exec|maven|assembly|config|include|log|new|skip) +\\bjitsi +jitsi-videobridge +meet[-.]jit[-.]si + +\?pwd=[0-9a-z]+ +(?:pwd|ufrag)="[0-9a-z]+" +"(?:pwd|ufrag|id)": "[a-zA-Z0-9+]+" + id="[a-f0-9-]+" + +4aca6ed6 +7d2b7ecf + +period\}ically + +https://github.com/[^/]+/[^/]+/blob/[0-9a-f]+/ + +(?:[A-F0-9]{2}:){29}[A-F0-9]{2} +(?:0[Xx]|U\+|#)[a-f0-9A-FGgRr]{2,}[Uu]?[Ll]?\b +\{[0-9A-FA-F]{8}-(?:[0-9A-FA-F]{4}-){3}[0-9A-FA-F]{12}\} + +\b([A-Za-z])\1{3,}\b + +<((?:[a-z]+\.|)version)>[0-9.-]+?-[0-9a-z]+ diff --git a/.github/actions/spell-check/whitelist/README.md b/.github/actions/spell-check/whitelist/README.md new file mode 100644 index 0000000000..c45ecb5c30 --- /dev/null +++ b/.github/actions/spell-check/whitelist/README.md @@ -0,0 +1,9 @@ +The contents of each `.txt` file in this directory are merged together. + +* [jitsi](jitsi.txt) general jitsi specific whitelist items +* [debian](debian.txt) for debian specific magic +* [names](names.txt) for names or people/companies/projects +* [systemd](systemd.txt) for systemd specific stuff +* [whitelist](whitelist.txt) is the main whitelist -- there is nothing +particularly special about the file name (beyond the extension which is +important). diff --git a/.github/actions/spell-check/whitelist/debian.txt b/.github/actions/spell-check/whitelist/debian.txt new file mode 100644 index 0000000000..381a34f524 --- /dev/null +++ b/.github/actions/spell-check/whitelist/debian.txt @@ -0,0 +1,47 @@ +buildinfo +buildpackage +changelog +charset +chmod +chown +dch +DEBEMAIL +DEBFULLNAME +debhelper +deconfigure +deluser +devscripts +dh +dpkg +elif +getent +gettext +grep +groupadd +groupdel +installdeb +installinit +installsystemd +logz +manpage +msgid +msgstr +nf +nh +noscripts +nroff +OLDCONFIG +passwd +postinst +postrm +pwgen +roff +statoverride +systemctl +urandom +useradd +usermod +uuidgen +xmllint +xmpp +xpath diff --git a/.github/actions/spell-check/whitelist/jitsi.txt b/.github/actions/spell-check/whitelist/jitsi.txt new file mode 100644 index 0000000000..c9dc66d7ef --- /dev/null +++ b/.github/actions/spell-check/whitelist/jitsi.txt @@ -0,0 +1,408 @@ +actpass +agafua +alloc +ALR +antrun +api +apps +architecting +argparse +args +arraycopy +astype +attr +audiochannels +backend +bandwidthestimation +basedir +bc +bitrate +bitratecontroller +bitstream +bsib +buf +bw +BWD +bwe +cafebabe +callstatsio +cdebug +cfg +cgi +changeit +changeme +checkstyle +classname +classpath +classpathref +clazz +clockrate +codehaus +concat +config +confmodule +conninput +copytruncate +cors +cpe +cpr +ctor +datachannel +datachannelstack +DCEP +dcp +dealloc +debconf +debian +Decodability +delaycompress +demux +deserialize +deserialized +Deserializer +dest +df +dirname +DISPLAYNAME +dnctl +downscale +downscaling +drawstyle +dsi +dst +dtls +dummynet +easymock +EB +ecparam +ecpriv +ecpubkey +edu +eid +enabledelayedexpansion +endian +enum +eol +eps +ev +eventadmin +evt +expireable +expr +failonerror +fasterxml +fbs +findbugs +firefox +firewalls +FIXME +FMJ +framerate +func +gcc +genkey +geolocation +getopts +groovysh +gz +hardcoded +hardcoding +Hashtable +hdr +hdrext +heapdump +hk +Hn +Homepage +hostname +hprof +href +html +http +iae +idx +ieeexplore +ietf +igniterealtime +impl +Inet +instanceof +ioe +ip +iptables +iqversion +ISAC +javadoc +javascript +javax +jdk +jicoco +jicofo +jid +Jigasi +jitsi +jitsimeet +jks +jmap +jmt +jq +jre +json +jstack +junit +jvb +jvbsecret +jvm +jwk +jxmpp +KClass +keyframe +keystore +kf +Knowledgements +ktlint +lastn +len +libjitsi +lightbend +linestyle +linux +Localpart +lsof +Lsw +markersize +matplotlib +Mbit +mediacapture +Middlebox +millis +minptime +missingok +mkfifo +mmin +mockito +msid +Msw +muc +mucclient +multipoint +multistream +Multistreaming +mvn +mvnrepository +MVNVER +myfocus +myuser +nack +namespace +nargs +NChanged +NEndpoints +netdev +nfe +NFilter +nginx +NIds +nio +NJson +nlj +nodelay +notifempty +npmjs +NPROC +ntp +nums +NValue +octo +OOM +OPTARG +OPTIND +osgi +oversending +Packetizer +packetlogging +params +pb +pcap +PCMA +PCMU +PDV +pem +pfctl +picidx +pictureid +pinterest +plr +plt +plugin +PNAME +powermock +ppid +println +prioritization +procps +programname +proj +PROPFILE +prosodyctl +pubout +pubsub +pwd +px +pyplot +rbe +Rcv +RCVBUF +readlink +README +readonly +recv +recvonly +refactor +refactoring +regex +regexp +remb +REXMIT +rfc +Rflag +rmcat +rmem +RRs +Rtc +rtcp +rtcpfb +rtcpmux +RTCPT +rtcweb +rtp +rtt +rtx +ruleset +rusv +rx +scalability +sce +sctp +sctpconnection +sctpmap +sdp +sendonly +sendrecv +seqnum +Serializer +servlet +SETLOCAL +sfu +sgpe +sharex +shyiko +sid +slf +smackx +Snd +SNDBUF +spamming +spe +spi +spotbugs +src +srflx +srtp +ssl +ssltcp +ssma +ssn +ssrc +SSRCAs +startcode +stderr +stdin +stdlib +STDOUT +ste +stringprep +subdomain +subfolder +subparsers +sudo +suptitle +SYS +syslog +sz +taskname +TCCs +tcp +tcptype +td +testutils +tgz +Throwable +timeseries +tl +todo +toffset +tpe +tpp +tsn +tt +turnrelay +typesafe +udp +ufrag +uid +Uint +ul +ulimit +ulpfec +umd +uncomment +unregister +unregistering +unsubscribe +Uploaders +upscaling +uri +url +usecases +useinbandfec +username +usrsctp +UTF +utils +uuid +videobridge +videochannel +videoconferencing +videostreams +VZ +webrtc +webrtchacks +websocket +Whitebox +wil +WMI +wrt +www +Xallow +xdata +Xdebug +xep +xffff +XForwarded +xlabel +xlarge +Xlint +xml +xmlns +xmlpull +xmppserver +Xmx +xpp +Xrunjdwp +xsd +xsi +xslt +ylabel +zcvf +zgrep diff --git a/.github/actions/spell-check/whitelist/names.txt b/.github/actions/spell-check/whitelist/names.txt new file mode 100644 index 0000000000..b8e3a9d5d2 --- /dev/null +++ b/.github/actions/spell-check/whitelist/names.txt @@ -0,0 +1,40 @@ +alvestrand +Atlassian +AWS +Baldino +bbaldino +bluejimp +boris +bugzilla +Cthulhu +damencho +Domas +emcho +gdb +github +google +googlecode +Grozev +holmberg +holmer +Hristo +Ivov +jetbrains +jivesoftware +kotlin +kotlintest +Lyubomir +Marinov +Minkov +mmusic +mozilla +neomedia +openjdk +openssl +Pawel +Politis +Pramatarov +Terezov +ubuntu +wireshark +yasen diff --git a/.github/actions/spell-check/whitelist/pom-version.txt b/.github/actions/spell-check/whitelist/pom-version.txt new file mode 100644 index 0000000000..7f9f3d4fde --- /dev/null +++ b/.github/actions/spell-check/whitelist/pom-version.txt @@ -0,0 +1,4 @@ +# these entries come from pom.xml <..version>here +# there's a patterns.txt rule to exclude them, but it isn't working +gf +gfcf diff --git a/.github/actions/spell-check/whitelist/systemd.txt b/.github/actions/spell-check/whitelist/systemd.txt new file mode 100644 index 0000000000..0e21c5ed7c --- /dev/null +++ b/.github/actions/spell-check/whitelist/systemd.txt @@ -0,0 +1,19 @@ +authbind +callstats +chuid +esac +localhost +LOGFILE +logrotate +lsb +MAINPID +mkdir +pid +pidfile +sbin +sdk +sysctl +systemd +tmp +tmpfs +TMPPATH diff --git a/.github/actions/spell-check/whitelist/whitelist.txt b/.github/actions/spell-check/whitelist/whitelist.txt new file mode 100644 index 0000000000..73752c9aea --- /dev/null +++ b/.github/actions/spell-check/whitelist/whitelist.txt @@ -0,0 +1 @@ +usr diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml new file mode 100644 index 0000000000..104c094af5 --- /dev/null +++ b/.github/workflows/spelling.yml @@ -0,0 +1,21 @@ +name: Spell checking +on: + push: + branches: + - "**" + tags-ignore: + - "**" + +jobs: + build: + name: Spell checking + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2.0.0 + with: + fetch-depth: 5 + - uses: check-spelling/check-spelling@0.0.15-alpha + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + bucket: .github/actions + project: spell-check