Kotest dependencies fixes #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undled into a single version property.
LouisCAD
requested changes
Sep 29, 2021
plugins/dependencies/src/main/resources/refreshVersions-rules/testing-version-alias-rules.txt
Outdated
Show resolved
Hide resolved
plugins/dependencies/src/test/resources/dependencies-versions-key-validated.txt
Outdated
Show resolved
Hide resolved
Kantis
force-pushed
the
kotest-dependencies
branch
from
625a532
to
5200d63
Compare
|
There's no need for one rule per artifact. You can use stars, see the examples in other rules already in refreshVersions (linked from the contributing docs). |
|
Ah, thank you! That's much nicer 😃 |
|
Thanks for the contribution! |
|
It looks like the PR is not based on the main branch from 2 days ago as the PR submission would suggest, but it based on a commit from over 3 weeks ago 🤔 |
|
Also looks like you initially, correctly commited the |
LouisCAD
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
kotest-extensions-springmight be 2.0.0 whilekotest-extensions-koinmight still be at1.1.0. Currently, these are bundled into a single versioning property.Testing.kotest.framework.apiforkotest-framework-apiandTesting.kotest.framework.datatestforkotest-framework-datatest)Please let me know if I missed something.