Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pt_PT locale #138

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Add pt_PT locale #138

merged 2 commits into from
Jul 5, 2020

Conversation

rjgpacheco
Copy link
Contributor

This pull request add support for European Portuguese, pt_PT.

This is based on the existing pt_BR translation, but with two changes:

  • Changed the %s from now message from em %s to daqui a %s, which I believe sounds more natural for European Portuguese;
  • Changed the translations of numbers over million to account for the fact that European Portuguese uses long scale instead of Brazilian Portuguese, which uses short scale. This means that billion in English would translate to mil milhões (thousand million) in European Portuguese.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2020

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files           9        9           
  Lines         421      421           
=======================================
  Hits          418      418           
  Misses          3        3           
Flag Coverage Δ
#GHA_Ubuntu 99.28% <ø> (ø)
#GHA_Windows 99.28% <ø> (ø)
#GHA_macOS 99.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976ad4a...a01722f. Read the comment docs.

@hugovk hugovk added changelog: Added For new features enhancement New feature or request labels Jul 5, 2020
@hugovk hugovk merged commit 40f00a5 into jmoiron:master Jul 5, 2020
@hugovk
Copy link
Collaborator

hugovk commented Jul 5, 2020

Thank you!

(The few CI failures is flaky Codecov coverage upload, unrelated.)

@rjgpacheco rjgpacheco deleted the add-pt_pt branch July 5, 2020 17:55
@rjgpacheco
Copy link
Contributor Author

Thank you @hugovk !

@hugovk
Copy link
Collaborator

hugovk commented Jul 5, 2020

And released in version 2.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants