Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalise a previously hardcoded 'and' #163

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Internationalise a previously hardcoded 'and' #163

merged 3 commits into from
Sep 30, 2020

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Sep 29, 2020

Fixes #161.

Changes proposed in this pull request:

  • There was a hardcoded " and "
  • Internationalise it instead
  • Add translations for those I can, leave empty for the others (via scripts/update-translations.sh)

@hugovk hugovk added bug Something isn't working changelog: Fixed For any bug fixes labels Sep 29, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          556       560    +4     
=========================================
+ Hits           556       560    +4     
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows 100.00% <100.00%> (ø)
#GHA_macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/humanize/i18n.py 100.00% <ø> (ø)
src/humanize/time.py 100.00% <100.00%> (ø)
tests/test_i18n.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345f58b...6bf67c7. Read the comment docs.

@hugovk hugovk merged commit 90f5b21 into jmoiron:master Sep 30, 2020
@hugovk hugovk deleted the i18n-and branch September 30, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hardcoded conjunction in precisedelta()
2 participants