Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support py3.9 #171

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Add initial support py3.9 #171

merged 2 commits into from
Oct 19, 2020

Conversation

jaimcamp
Copy link

Changes proposed in this pull request:

  • Adds support for python 3.9 in the tox environment, github actions, setuptools and Travis.

@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          569       569           
=========================================
  Hits           569       569           
Flag Coverage Δ
#GHA_Ubuntu 100.00% <ø> (ø)
#GHA_Windows 100.00% <ø> (ø)
#GHA_macOS 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809e66b...b0fe8eb. Read the comment docs.

@jaimcamp jaimcamp mentioned this pull request Oct 19, 2020
4 tasks
@hugovk
Copy link
Collaborator

hugovk commented Oct 19, 2020

Thanks!

We're still waiting for 3.9 on Travis CI (https://travis-ci.community/t/python-3-9-0-build/10091?u=hugovk) so please can you leave it on 3.9-dev for now? We can update that later when it's available.

The PyPy3 / Windows failure looks unrelated, also occurs on master and already reported at actions/setup-python#151, so let's not worry about that here.

@jaimcamp
Copy link
Author

Thanks!

We're still waiting for 3.9 on Travis CI (https://travis-ci.community/t/python-3-9-0-build/10091?u=hugovk) so please can you leave it on 3.9-dev for now? We can update that later when it's available.

The PyPy3 / Windows failure looks unrelated, also occurs on master and already reported at actions/setup-python#151, so let's not worry about that here.

Got it, pushed a commit to roll-back the support in travis, can be easily revered in the future 👍

@jaimcamp jaimcamp marked this pull request as ready for review October 19, 2020 18:29
@jaimcamp jaimcamp changed the title [WIP] Add initial support py3.9 Add initial support py3.9 Oct 19, 2020
@hugovk hugovk added hacktoberfest-accepted To credit accepted Hacktoberfest PRs changelog: Added For new features enhancement New feature or request labels Oct 19, 2020
@hugovk hugovk merged commit c3152b6 into jmoiron:master Oct 19, 2020
@hugovk
Copy link
Collaborator

hugovk commented Oct 19, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features enhancement New feature or request hacktoberfest-accepted To credit accepted Hacktoberfest PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants