Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging on every layer change ? #18

Open
j-snijder opened this issue Oct 30, 2022 · 20 comments
Open

Messaging on every layer change ? #18

j-snijder opened this issue Oct 30, 2022 · 20 comments
Labels
enhancement New feature or request

Comments

@j-snijder
Copy link

Installed the plugin and tested it, to my surprise it did work on my setup.

One problem though, it messages me on every layer change with a spoken message which is not related to the choosen option ?

@jneilliii
Copy link
Owner

This is probably because display layer progress is sending those m117 messages.

@j-snijder
Copy link
Author

j-snijder commented Oct 31, 2022 via email

@jneilliii
Copy link
Owner

You could disable that plugin would be one way, but then you won't get the updates on the printer's screen. I could potentially add a filtering option similar to terminal filters that would allow you to exclude those messages in a future update.

@jneilliii jneilliii added the enhancement New feature or request label Oct 31, 2022
@jneilliii
Copy link
Owner

small note to myself to implement the same filtering I have in M117 Pop Up here.

@j-snijder
Copy link
Author

j-snijder commented Oct 31, 2022 via email

@j-snijder
Copy link
Author

In the meantime I have reinstalled "displayLayerProgres" plugin for testing purposes.

Just give a yell and I'll dive into testing again :)

Regards, Jan

@j-snijder
Copy link
Author

j-snijder commented Oct 31, 2022

Extra note on the subject:

On my cellphone it calls out the text that is in the small floating window on top of OP, so that's at least somewhat like it should be ?

@j-snijder
Copy link
Author

STOP the presses :)

Works !!

What did I have to do ?

In DisplayLayerProgress I had to change the Message Output on the Printer Display settings to the info I wanted to hear.

In my Case (Dutch) it had to be : "Voortgang [progress]% Huidige printlaag [current_layer] Nog [printtime_left] te gaan" for it to work as I wanted.

One remark on this though, th "m" in [printtime_left] is spoken as meter but needs to be minutes !
Anyway how to change that ?

It took me a while to discover where MY problem was but found it and now understand (I hope) how to use the output.

If there is a way to make "m" ino minutes (or minuten, as I'm Dutch) I like to hear from you.

Thanks in advance, regards and greets

@jneilliii
Copy link
Owner

The plugin just speaks what is given on the m117 messages. I don't use that other plugin so have no idea what options are available for making the messages what you want. Maybe a question for its issue tracker/docs.

@j-snijder
Copy link
Author

j-snijder commented Oct 31, 2022

After some more testing it seems that it happens that after a few times speaking out the riht text it goes bezirk and the plugin falls back to "Dasboard_Layer_Indicator"
This happens every 5 or 6 times, and then goes back to what its supposed to do, and 5 or 6 times later again the "DLI"

As I now have set the interval at 10 seconds I'll check if setting a wider time window of 30 seconds will solve this.

@j-snijder
Copy link
Author

The plugin just speaks what is given on the m117 messages. I don't use that other plugin so have no idea what options are available for making the messages what you want. Maybe a question for its issue tracker/docs.

I've uninstalled that plugin but that was not the issue, now only testing with DisplayLayerProgress

@j-snijder
Copy link
Author

Could that be my problem also ?? and why ?

OllisGit/OctoPrint-DisplayLayerProgress#266

@jneilliii
Copy link
Owner

I told you that already, the other plugin adds those m117 messages to your files.I should have been more clear before that you need to disable that plugin and reupload your files if you don't want those layer messages.

@j-snijder
Copy link
Author

Ah, okay :( my bad, that part I didn't get :)

Okay I'll do that and report back :)

@j-snijder
Copy link
Author

Okay, disabled the displayLayerProgress plugin ad reloaded a small file.

Now were back to "Dasboard_Layer_Indicator xx" messages :(

At least when the DisplayLayerProgress plugin was installed I had the possibility to edit the text thats spoken, wich actually is nice.

Getting only a message on which layer the print is (whats happning now) is not what this plugin is meant for ? is it ?

@jneilliii
Copy link
Owner

You sure you don't have any other display plugin or your slicer might have on layer change code enabled? Maybe octolapse?

@j-snijder
Copy link
Author

Yes I also have that enabled :) so have to disable that to ?

Better then to disable all but m117speech synthesis you're saying ?

@j-snijder
Copy link
Author

j-snijder commented Nov 2, 2022

Have disabled octolapse too, still problem stays.

I'll abandon this plugin, sorry, is costing me too much time to find out what's wrong.

@jneilliii
Copy link
Owner

Well, I've told you over and over what's causing the issue. Something is embedded in your gcode either by plugin or slicer that is causing the M117 messages to be sent to your printer/this plugin. The plugin doesn't care how the messages get there and it will just speak them as intended as they are sent. I can't say what that is but my guess would be your slicer on layer change gcode is probably what is giving these last messages now. The easiest way to determine this is to slice a gcode and save to your computer, open that file in a text editor and search for M117 messages. If the messages are there then it is your slicer doing this. If they are not there then it is a plugin doing it.

@j-snijder
Copy link
Author

j-snijder commented Nov 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants