Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target to ES6 #5

Closed
mbalex99 opened this issue Oct 10, 2016 · 5 comments
Closed

Target to ES6 #5

mbalex99 opened this issue Oct 10, 2016 · 5 comments

Comments

@mbalex99
Copy link

Electron is ES6, so we should probably remove es6-shim and change the target in the tsconfig.json to es6

@joaogarin
Copy link
Owner

Yeah that makes sense. I will try to do a PR today for this. Will keep the issue updated on that ;O tks

@mbalex99
Copy link
Author

I think we can also remove core-js as well.

@joaogarin
Copy link
Owner

I think core-js will still be necessary for es7-reflect feature. I dont think thats implemented in any browser yet. Altough I am not entirely sure zloirock/core-js#152

@joaogarin
Copy link
Owner

joaogarin commented Oct 10, 2016

I dont think you can target ES6 actually with electron, and the reason is that ES6 modules are not yet implemented in any browser as far as I know..So I dont think this would be an option but I am trying to dig into that. https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Statements/import

@joaogarin
Copy link
Owner

I think I will close this one, as far as I can tell and from all the repos I found (including the official angular one altough still on beta.2) they all target es5, and I am pretty sure the reason is ES6 modules.

let me know if you find something else, or have some ideas on this. Feel free to reopen if you think there is something to be done still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants