Fix clang build with CppAD >= 2024 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CppAD 2024 add a `max_digits10` member to `CppAD::numeric_limits`. This member is not defined in CppADCodeGen and this create compilation issue with clang based compiler. To avoid future issue, we use `CPPAD_NUMERIC_LIMITS` macro that will ensure we always have an up to date version of `CppAD::numeric_limits`. See [CppAD#206](coin-or/CppAD#206).
jorisv
force-pushed
the
topic/fix_clang_cppad
branch
from
8dcfee0
to
d947019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
CppAD 2024 add a
max_digits10member toCppAD::numeric_limits.This member is not defined in CppADCodeGen and this create compilation issue with clang based compiler.
To avoid future issue, we use
CPPAD_NUMERIC_LIMITSmacro that will ensure we always have an up to date version ofCppAD::numeric_limits.See CppAD#206.
#87 should be merged before merging this PR.