Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Brave (new chrome based browser) #84

Closed
jeroenev opened this issue Nov 2, 2018 · 12 comments
Closed

Not working in Brave (new chrome based browser) #84

jeroenev opened this issue Nov 2, 2018 · 12 comments

Comments

@jeroenev
Copy link

jeroenev commented Nov 2, 2018

when installing the extension, it's not possible to login (login page doesn't appear)
also when checking the settings page none of the buttons/actions/tabs respond when clicking on them

@joaomgcd
Copy link
Owner

joaomgcd commented Nov 5, 2018

Sorry, Join was not meant to be used on browsers other than Chrome so I can't vouch for it working there...

@joaomgcd joaomgcd closed this as completed Nov 5, 2018
@jeroenev
Copy link
Author

jeroenev commented Nov 5, 2018

Too bad, it works fine in Vivaldi though, which is also a chrome based browser
Other extensions i use work fine in brave, seems like this is the only exception atm

@jeroenev
Copy link
Author

jeroenev commented Nov 5, 2018

But i guess it's up to Brave devs to fix compatibility, will report it there

@tommyent
Copy link
Contributor

tommyent commented Nov 5, 2018

I think only the beta/dev of Brave is currently Chromium. I've tested and it worked fine for me.

@jeroenev
Copy link
Author

jeroenev commented Nov 5, 2018

@tommyent if you currently download the stable version it's already chromium based, though the old muon based version won't automatically update to the chromium base atm as far as i'm aware
I'll test the beta later to see if it's just an issue in the current stable version

@jeroenev
Copy link
Author

jeroenev commented Nov 5, 2018

Tested extension again on stable, seems to work
Not sure what caused it to break completely when i tried it before, but it seems to be fixed, so this ticket can stay closed 😃

@dogancelik
Copy link

Brave uses Chromium (Chrome) so I'd appreciate if you can try to fix this issue.

On diagnostics page, I get alert() at step 2 Testing registration on Join's server...:

Unknown error: TypeError: Cannot read property 'where' of null

diag2

@jeroenev
Copy link
Author

jeroenev commented Jan 2, 2019

getting similar error, but the sending push to server... also gives an error for me
however, pushing tabs to my phone seems to work fine
EDIT: on linux i don't get the registration error
everything seems to work fine, except the two receiving pushes checks don't work
chrome://gcm-internals shows state "INITIALIZED" instead of "CONNECTED"
maybe that's the cause?
is there no backup to use if GCM doesn't work?
that could be a major roadblock for people that use anything but googles native chrome browser, or people that use an android device without play services

@tommyent
Copy link
Contributor

tommyent commented Jan 2, 2019

@dogancelik @jeroen7s Brave disabled both GCM and FCM (Oct/Nov) so currently it will no longer work with Brave.

@jeroenev
Copy link
Author

jeroenev commented Jan 3, 2019

Just today opened my browser and the test notifications which failed yesterday have arrived
in diagnostics the "Receiving Push from server..." no longer fails,
only the "Receiving Push with GCM key..." still fails, but that's to be expected.
The important part is that receiving pushes works now 👍

@mickdekkers
Copy link

Good news: Join now works in Brave 🎉

You just need to enable the "Google Services for Push Messaging" setting in Brave for it to work. See brave/brave-browser#2408 (comment)

After you've done this, all the tests in the diagnostics tab will pass:

A screenshot of Join's diagnostics tab, taken after running the tests in Brave. All the tests have passed.

Tested on Brave Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit).

@joaomgcd
Copy link
Owner

joaomgcd commented Jan 8, 2020

Nice :D Thanks for letting us know!

@joaomgcd joaomgcd reopened this Jan 8, 2020
@joaomgcd joaomgcd closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants