From 3b6934239424bdebb8d51fb4a297c524f88bef99 Mon Sep 17 00:00:00 2001 From: Hannes Diercks Date: Thu, 15 Nov 2018 16:42:57 +0100 Subject: [PATCH 1/2] fix: create exact same delta as a user-operated quill instance by setting delta as content to quill and then returning the content fix https://github.com/joelcolucci/node-quill-converter/issues/3 BREAKING CHANGE: This likely alters the result of any convertHtmlToDelta conversion. Depending of what people are doing with the delta this might break things. --- lib/index.js | 3 ++- test/node-quill-converter.test.js | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/index.js b/lib/index.js index d571a43..f4e955b 100644 --- a/lib/index.js +++ b/lib/index.js @@ -43,8 +43,9 @@ exports.convertTextToDelta = (text) => { exports.convertHtmlToDelta = (html) => { let delta = QUILL.clipboard.convert(html); + QUILL.setContents(delta); - return delta; + return QUILL.getContents();; }; exports.convertDeltaToHtml = (delta) => { diff --git a/test/node-quill-converter.test.js b/test/node-quill-converter.test.js index d44d1a0..c9044ec 100644 --- a/test/node-quill-converter.test.js +++ b/test/node-quill-converter.test.js @@ -25,6 +25,9 @@ describe('node-quill-converter', () => { attributes: { bold: true } + }, + { + insert: "\n" } ] }; From db3b0729af36c4e4dc6a21b984e73cce2499dd39 Mon Sep 17 00:00:00 2001 From: Hannes Diercks Date: Thu, 15 Nov 2018 16:44:11 +0100 Subject: [PATCH 2/2] test: fix typo --- test/node-quill-converter.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/node-quill-converter.test.js b/test/node-quill-converter.test.js index c9044ec..6d41e17 100644 --- a/test/node-quill-converter.test.js +++ b/test/node-quill-converter.test.js @@ -37,7 +37,7 @@ describe('node-quill-converter', () => { expect(deltaResult).toEqual(deltaExpected); }); - it('convertHtmlToDelta', () => { + it('convertDeltaToHtml', () => { let delta = { ops:[ {