From 951291dfcd7b49c7a4b0af084bc7ddc9570b0b69 Mon Sep 17 00:00:00 2001 From: Joel Drapper Date: Fri, 13 Dec 2024 02:34:17 +0000 Subject: [PATCH] Remove the option to disable checks (#259) --- lib/literal.rb | 2 -- lib/literal/property.rb | 40 +++++++++++++--------------------------- 2 files changed, 13 insertions(+), 29 deletions(-) diff --git a/lib/literal.rb b/lib/literal.rb index d96b3d9..c8c4175 100644 --- a/lib/literal.rb +++ b/lib/literal.rb @@ -1,8 +1,6 @@ # frozen_string_literal: true module Literal - TYPE_CHECKS_DISABLED = ENV["LITERAL_TYPE_CHECKS"] == "false" - autoload :Array, "literal/array" autoload :Data, "literal/data" autoload :DataProperty, "literal/data_property" diff --git a/lib/literal/property.rb b/lib/literal/property.rb index 65e33fc..374d26d 100644 --- a/lib/literal/property.rb +++ b/lib/literal/property.rb @@ -118,29 +118,18 @@ def generate_reader_method(buffer = +"") "\n value\nend\n" end - if Literal::TYPE_CHECKS_DISABLED - def generate_writer_method(buffer = +"") - buffer << - (@writer ? @writer.name : "public") << - " def " << - @name.name << - "=(value)\n" << - " @#{@name.name} = value\nend\n" - end - else # type checks are enabled - def generate_writer_method(buffer = +"") - buffer << - (@writer ? @writer.name : "public") << - " def " << - @name.name << - "=(value)\n" << - " self.class.literal_properties[:" << - @name.name << - "].check_writer(self, value)\n" << - " @" << @name.name << " = value\n" << - "rescue Literal::TypeError => error\n error.set_backtrace(caller(1))\n raise\n" << - "end\n" - end + def generate_writer_method(buffer = +"") + buffer << + (@writer ? @writer.name : "public") << + " def " << + @name.name << + "=(value)\n" << + " self.class.literal_properties[:" << + @name.name << + "].check_writer(self, value)\n" << + " @" << @name.name << " = value\n" << + "rescue Literal::TypeError => error\n error.set_backtrace(caller(1))\n raise\n" << + "end\n" end def generate_predicate_method(buffer = +"") @@ -171,10 +160,7 @@ def generate_initializer_handle_property(buffer = +"") generate_initializer_coerce_property(buffer) end - unless Literal::TYPE_CHECKS_DISABLED - generate_initializer_check_type(buffer) - end - + generate_initializer_check_type(buffer) generate_initializer_assign_value(buffer) end