Makes the necessary setup for Travis CI #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid issues such as joemccann#514 and to allow Travis CI to run unit test.
This commit also updates karam to 0.13.22 to avoid karma-runner/karma#1782 (sockets.forEach is not a function) when running gulp test.
| @@ -0,0 +1,5 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "5.10.1" | |||
There was a problem hiding this comment.
I couldn't get npm to install gulp properly with node version 4.4.3 (I'm guessing it has something to do with an older version of npm).
This shouldn't mater because we don't have any server side tests yet (and the tests are running in PhantomJS anyway).
@joemccann I'll fix this issue when we setup server side tests (which I want to discuss with you on Slack).
|
Once Travis CI is enabled a red X will appear on broken pull requests like #513, and clicking it should lead you to the failed build log. |
|
awesome work |
joemccann
added a commit
that referenced
this pull request
May 8, 2016
Makes the necessary setup for Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've discussed on Slack I've:
testtask to Gulp and setup Travis CI.npm installrungulp build --prodto avoid issues (like cannot find the file app/public/css/app.css after deploying to heroku #514).When you enable Travis CI on your repo and someone opens a pull request (or pushes a commit):
npm install(which runsgulp build --prod) is ran.gulp testis ran, which runs the tests.I've already enabled Travis CI on my fork, click on the badge for details:
@joemccann To enable Travis CI on your repo you should:
I wanted to add the Travis CI badge to the project's Readme but until we implement the React preview the badge image will be reloaded each time a debounce occurs (the user types).
And since these badges are dynamic (they will change depending on the projects build status) they are not cached so it's not very elegant to watch it flashing as you type.
I can't wait to open a PR for the React preview and the build passing badge :)
I also updated Karma to version
0.13.22to avoid karma-runner/karma#1782 after successfully running the new test task.