Skip to content

feat: Bump mermaid version 10.9.1 to 11.3.0 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MaciejKucia
Copy link
Contributor

Simply updates mermaid dependency to enable glorious new diagramming features

Copy link
Owner

@johanneswuerbach johanneswuerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, I've left a few comments that would need to be addressed before merging this.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "backstage-plugin-techdocs-addon-mermaid",
"version": "0.13.0",
"version": "0.14.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this change? I'll bump the version once the PR has been merged.

@@ -224,8 +224,6 @@ graph LR
C --> E("$$x(t)=c_1\begin{bmatrix}-\cos{t}+\sin{t}\\ 2\cos{t} \end{bmatrix}e^{2t}$$")
```

## Not yet supported

### ZenUml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik ZenUml requires another package, did this change? https://mermaid.js.org/syntax/zenuml.html#integrating-with-your-library-website

@MaciejKucia MaciejKucia force-pushed the bump-mermaid-version branch from 46f3722 to 4ce8a3b Compare October 7, 2024 14:25
@karlhaworth
Copy link

@MaciejKucia and @johanneswuerbach I look forward to this PR being merged! We wish to use the architecture-beta chart!

@johanneswuerbach
Copy link
Owner

Thanks @MaciejKucia for the PR, I took the liberty to finish this #56 and released it as backstage-plugin-techdocs-addon-mermaid@0.14.0

@MaciejKucia
Copy link
Contributor Author

Thanks, could not figure out how to test this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants