Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Tumblr Search downloader - 'query' with special characters (encoded) like " or ' + () to exact-match #266

Closed
TarekJor opened this issue Sep 10, 2018 · 1 comment
Assignees
Labels

Comments

@TarekJor
Copy link

TarekJor commented Sep 10, 2018

Versions: from 'old' builds like v1.0.8.50 to last v1.0.8.58

Thanks for the app works like a charm and it is stable :D but I have some issues with 'Tumblr Search' type and 'query' syntax (I suppose).... For example

url => https://www.tumblr.com/search/%22The+Witcher%22+Geralt
query => "The+Witcher"+Geralt (decoded)
or
query => "muscle+cars"+Ford (decoded)
(none of those seem to work) *(1)
but query => muscle+cars+Ford (works)
I think Tumblr API supports 'complex queries' using "exact matches" and similar syntax to reduce output 'noise'.

*(1): The app seems in a loop, but no errors or messages (all the rest 'types' are working including auth-based blogs, liked/by, complete blogs etc... that is the only issue I noticed.

I wonder if it is a explicit restriction to 'query' or not, or if this is a particular problem in my setup or something, any ideas?

@johanneszab johanneszab self-assigned this Sep 17, 2018
johanneszab added a commit that referenced this issue Sep 19, 2018
- Improves the url encoding handling.
- Removes unnecessary cookie loading in the AbstractTumblrCrawler and TumblrSearchCrawler.
- Renames the TumblrAbstractCrawler to AbstractTumblrCrawler.
@TarekJor
Copy link
Author

Thanks for the fast response, your code is clean and tidy, I like that very much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants