Implement webhook validations for the XGBoostJob (kubeflow#2052)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge · Apr 28, 2024 · 0e3dd5c · 0e3dd5c
1 parent f469162
commit 0e3dd5c
Show file tree

Hide file tree

Showing 9 changed files with 427 additions and 317 deletions.
diff --git a/manifests/base/webhook/manifests.yaml b/manifests/base/webhook/manifests.yaml
@@ -44,3 +44,23 @@ webhooks:
     resources:
     - tfjobs
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-kubeflow-org-v1-xgboostjob
+  failurePolicy: Fail
+  name: validator.xgboostjob.training-operator.kubeflow.org
+  rules:
+  - apiGroups:
+    - kubeflow.org
+    apiVersions:
+    - v1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - xgboostjobs
+  sideEffects: None
diff --git a/manifests/base/webhook/patch.yaml b/manifests/base/webhook/patch.yaml
@@ -4,6 +4,9 @@
 - op: replace
   path: /webhooks/1/clientConfig/service/name
   value: training-operator
+- op: replace
+  path: /webhooks/2/clientConfig/service/name
+  value: training-operator
 - op: replace
   path: /metadata/name
   value: validator.training-operator.kubeflow.org
diff --git a/pkg/apis/kubeflow.org/v1/xgboost_validation.go b/pkg/apis/kubeflow.org/v1/xgboost_validation.go
diff --git a/pkg/apis/kubeflow.org/v1/xgboost_validation_test.go b/pkg/apis/kubeflow.org/v1/xgboost_validation_test.go