UnDiscoverables Plugin

[Data-Monkey]

Hi,
so I am trying to make a plugin for all these pesky "dumb" network devices that we would like to see in the network view.

Work in progress here: https://github.com/Data-Monkey/Pi.Alert/tree/undiscoverables_plugin

The goal is to read a list of devices from a file or maybe a param in the frontend and generate the devices.

[Data-Monkey]

I have some question on how the plugin works. Yes, I did read the plugins readme but I am missing something.

So far my script generates the last_results.log file and the devices in there are recognised and are added to the plugin_objects table in the DB.

What do I need to do to make them show up in the devices? I believe it has to be in the config.json file but I can't work it out.
Do I need to map them to an existing table? I tried to map to a new table but that did not work as the table does not get created. What table do I need to map them too?

thanks

[jokob-sk]

For the input you could use the list setting type: https://github.com/jokob-sk/Pi.Alert/blob/941a8ef66171d32ccfedbc9d79be03a08f18aa7a/front/plugins/website_monitor/config.json#L352

or create a different input form control for a new setting type.

The list setting type is then resolved like this:

The actual implementation can be found here: https://github.com/jokob-sk/Pi.Alert/blob/941a8ef66171d32ccfedbc9d79be03a08f18aa7a/front/settings.php#L248

[jokob-sk]

I just tried the current scan table but it needs a scan id and I did not see an easy way of generating the right one.

I think it's not really used and it's fine to use the number 1

[jokob-sk]

I've added some quick docs on teh DB structure: https://github.com/jokob-sk/Pi.Alert/blob/main/docs/DATABASE.md

[Data-Monkey]

yes, I tried that as well and I can add the data.
I discovered that the plugin mapping to tables happens after the scan is finished. So adding more records to the CurrentScan table does not help, as at the start of the next scan it gets deleted (see def save_scanned_devices (line 1248 in pialert.py) ) .
So the plugin data never goes anywhere.
We would need t do the data mapping after the scan but before the processing of the scan.

With DHCP_Leases it works.

[Data-Monkey]

I have a working version now I believe.
Is there a special way you would like me to test it or to submit a PR?
https://github.com/Data-Monkey/Pi.Alert/tree/undiscoverables_plugin

[jokob-sk]

Closing as released