Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi.Alert shows fqdn with no dot separators e.g. "hostdomaincom" instead of "host.domain.com" #165

Closed
harr2969 opened this issue Feb 3, 2023 · 10 comments
Labels
Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.

Comments

@harr2969
Copy link

harr2969 commented Feb 3, 2023

I've got pi.alert learning via pi.hole, nmap and pholus.

About 35 of my ~40 devices on the home network are showing as "hostdomaincom" instead of "host.domain.com"

If I look in my pi.hole docker (for example "top 10 clients") they show correctly with "host.domain.com"

Any suggestions on how I can determine where this is breaking and what's the most effective way to fix it?

See docker run and other info on issue 164, and .conf excerpt below.

18:35:44 root@nas:/volume1/docker/pialert/config# cat pialert.conf

General

#---------------------------
ENABLE_ARPSCAN=True
SCAN_SUBNETS=['192.168.1.0/24 --interface=eth1']
PRINT_LOG=False
TIMEZONE='Europe/London'
PIALERT_WEB_PROTECTION=False
PIALERT_WEB_PASSWORD='8d969eef6ecad3c29a3a629280e686cf0c3f5d5a86aff3ca12020c923adc6c92'
INCLUDED_SECTIONS=['internet','new_devices','down_devices','events']
SCAN_CYCLE_MINUTES=5
DAYS_TO_KEEP_EVENTS=90
REPORT_DASHBOARD_URL='http://pi.alert/'
DIG_GET_IP_ARG='-4 myip.opendns.com @resolver1.opendns.com'

PiHole

#---------------------------
PIHOLE_ACTIVE=True
DHCP_ACTIVE=True

Pholus

#---------------------------
PHOLUS_ACTIVE=True
PHOLUS_TIMEOUT=20
PHOLUS_FORCE=False
PHOLUS_RUN='schedule'
PHOLUS_RUN_TIMEOUT=600
PHOLUS_RUN_SCHD='0 4 * * *'
PHOLUS_DAYS_DATA=7

Nmap

#---------------------------
NMAP_ACTIVE=True
NMAP_TIMEOUT=150
NMAP_RUN='none'
NMAP_RUN_SCHD='0 2 * * *'
NMAP_ARGS='-p -10000'

EXCLUDED DISABLED SECTIONS

@jokob-sk
Copy link
Owner

jokob-sk commented Feb 3, 2023

I think I've found the issue. Can you try deploying this dev build to see if the issue is fixed?

DockerHub image tag is:

jokobsk/pi.alert_dev:sha-b5f0a64

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Feb 3, 2023
@harr2969
Copy link
Author

harr2969 commented Feb 5, 2023

Ok, trying, thanks.

@harr2969
Copy link
Author

harr2969 commented Feb 5, 2023

Restarting with the existing DB didn't seem to resolve the issue, but clearing the hosts from the maint menu and letting it reload did. Thanks!

@jokob-sk
Copy link
Owner

jokob-sk commented Feb 5, 2023

Cool, closing 😉

@jokob-sk jokob-sk closed this as completed Feb 5, 2023
@harr2969
Copy link
Author

harr2969 commented Feb 6, 2023

NP - will this be merged back into the main branch in future? (How long should I keep running the fork?)

@jokob-sk
Copy link
Owner

jokob-sk commented Feb 6, 2023

yes, will be fixed in the next release

@killtux
Copy link

killtux commented Mar 11, 2023

cool to see the new release fixed it. but now devices show up with dot between domain & hostname.... and one additional after the domain 😅

image

@jokob-sk
Copy link
Owner

jokob-sk commented Mar 11, 2023 via email

@killtux
Copy link

killtux commented Mar 11, 2023

normally its "host.domain" without a second dot at the end i think?

jokob-sk added a commit that referenced this issue Mar 11, 2023
@jokob-sk
Copy link
Owner

jokob-sk commented Mar 11, 2023

Cool, understood, should be fixed with jokob-sk/Pi.Alert@6dd1448

Will be part of the next release (or hotfix, whichever comes first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.
Projects
None yet
Development

No branches or pull requests

3 participants