Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] isEmpty is not handling (unknown) #899

Open
jokob-sk opened this issue Nov 27, 2024 · 1 comment
Open

[core] isEmpty is not handling (unknown) #899

jokob-sk opened this issue Nov 27, 2024 · 1 comment
Labels
bug 🐛 Something isn't working

Comments

@jokob-sk
Copy link
Owner

          Also I want to point out a minor difficulty I had during development. I tried using the function `handleEmpty`  to handle the empty columns that this plugin doesn't manage (e.g. hostnames) expecting it to be the correct way of doing so.

That function set the empty values in the database to the string "null" while the system expects unknown values to be the string "(unknown)", and because of that plugins like AVAHISCAN did not count the hostnames as unknown and didn't even try to resolve their name.

I haven't changed the function to return "(unknown)" in case something else depends on the "null" value, but I thing it should, because right now it's quite misleading. Or if there really is an use for the current handleEmpty, than a function handleUnknown would be useful.

Originally posted by @KayJay7 in #896 (comment)

@jokob-sk jokob-sk added the bug 🐛 Something isn't working label Dec 2, 2024
@jokob-sk
Copy link
Owner Author

jokob-sk commented Dec 2, 2024

  • check and align where "null" and "(unknown)"/"(Unknown)" is used - use constants if possible
  • think about user data (fields that might contain these values)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant