You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also I want to point out a minor difficulty I had during development. I tried using the function `handleEmpty` to handle the empty columns that this plugin doesn't manage (e.g. hostnames) expecting it to be the correct way of doing so.
That function set the empty values in the database to the string "null" while the system expects unknown values to be the string "(unknown)", and because of that plugins like AVAHISCAN did not count the hostnames as unknown and didn't even try to resolve their name.
I haven't changed the function to return "(unknown)" in case something else depends on the "null" value, but I thing it should, because right now it's quite misleading. Or if there really is an use for the current handleEmpty, than a function handleUnknown would be useful.
That function set the empty values in the database to the string
"null"
while the system expects unknown values to be the string"(unknown)"
, and because of that plugins likeAVAHISCAN
did not count the hostnames as unknown and didn't even try to resolve their name.I haven't changed the function to return
"(unknown)"
in case something else depends on the"null"
value, but I thing it should, because right now it's quite misleading. Or if there really is an use for the currenthandleEmpty
, than a functionhandleUnknown
would be useful.Originally posted by @KayJay7 in #896 (comment)
The text was updated successfully, but these errors were encountered: