Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authors with duplicate email addresses get mixed up #424

Closed
grawity opened this issue Jul 12, 2015 · 3 comments
Closed

Authors with duplicate email addresses get mixed up #424

grawity opened this issue Jul 12, 2015 · 3 comments

Comments

@grawity
Copy link
Contributor

grawity commented Jul 12, 2015

See for example https://github.com/atheme/charybdis, which (as an artifact of svn2git import) has several authors with the same devnull@localhost address:

androsyn <devnull@localhost>
jilles <devnull@localhost>
nenolod <devnull@localhost>
...

In tig's main (commit log) view, the name column only shows "androsyn" next to all such commits, even though the individual commits are shown as authored by "nenolod <devnull@localhost>" or such.

(If I enable set mailmap, it works fine, since the mailmap translates all such commits to unique emails.)

tig v1 not affected, only tig v2.x.

@jonas
Copy link
Owner

jonas commented Jul 13, 2015

As you've found, Tig uses the email as the key in the author hashmap, where
the author name is taken from the first occurrence. Given that set mailmap works, I guess this is low priority?

On Sun, Jul 12, 2015 at 3:36 PM, Mantas Mikulėnas notifications@github.com
wrote:

See for example the atheme/charybdis repo, which (as an artifact of
svn2git import) has several authors with the same devnull@localhost
address:

androsyn devnull@localhost
jilles devnull@localhost
nenolod devnull@localhost
...

In tig's main (commit log) view, all commits have the name "androsyn" next
to them, even though the individual commits are shown as authored by
"nenolod devnull@localhost".

(If I enable set mailmap, it works fine, since the mailmap translates all
such commits to unique emails.)

tig v1 not affected, only tig v2.x.


Reply to this email directly or view it on GitHub
#424.

Jonas Fonseca

@alangpierce
Copy link

I'm running into this as well. I wrote a tool that makes a bunch of automated code changes, and I intentionally use a different author (but the same email address) when generating commits for those changes. For example, my normal author is Alan Pierce <alan@benchling.com>, but when I run the script, it uses decaffeinate <alan@benchling.com> as the author for the auto-generated commits. That way, someone using git blame will see the name as "decaffeinate" for those lines and know that they were generated by an automated tool and I don't necessarily have context on the code. But anyone can still look at the email field to see who ran the tool.

Now, people on my team who use tig are running the tool, and when they open tig, they see their name change to "decaffeinate" for all of their commits. It looks like every other git tool I know of handles this case correctly.

minaguib pushed a commit to minaguib/tig that referenced this issue Nov 28, 2016
This addresses the issue where an author name change "wins" and tig
shows it for all historical commits by same email under old names

Addresses jonas#526 , jonas/tig/jonas#424
minaguib pushed a commit to minaguib/tig that referenced this issue Nov 28, 2016
This addresses the issue where an author name change "wins" and tig
shows it for all historical commits by same email under old names

Addresses jonas/issues/526 and jonas/issues/424
@jonas
Copy link
Owner

jonas commented Nov 29, 2016

Fixed in #547

@jonas jonas closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants