Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind the default quit key binding doesn't work #483

Closed
johackim opened this issue Mar 10, 2016 · 4 comments
Closed

Unbind the default quit key binding doesn't work #483

johackim opened this issue Mar 10, 2016 · 4 comments

Comments

@johackim
Copy link

The unbinding bind main q none in my .tigrc doesn't work.
It's work only with bind generic q none

@jonas
Copy link
Owner

jonas commented Mar 10, 2016

Confirmed, looks like a regression.

@jonas jonas closed this as completed in ad71cae Apr 25, 2016
@nkouevda
Copy link

@jonas Unfortunately ad71cae breaks a different use case:

I used to do this in order to bind G to move-last-line in all views:

bind generic G move-last-line
bind main G none

But now this results in G being completely unbound in main, regardless of the order of those lines.

There is of course this workaround:

bind generic G move-last-line
bind main G move-last-line

But this seems worse than falling through to generic bindings when view-specific ones are unbound.

@jonas
Copy link
Owner

jonas commented Apr 27, 2016

Oops, forgot to put a test case for that. Will fix.

On Wed, Apr 27, 2016 at 2:36 PM, Nikita Kouevda notifications@github.com
wrote:

@jonas https://github.com/jonas Unfortunately ad71cae
ad71cae
breaks a different use case:

I used to do this in order to bind G to move-last-line in all views:

bind generic G move-last-line
bind main G none

But now this results in G being completely unbound in main, regardless of
the order of those lines.

There is of course this workaround:

bind generic G move-last-line
bind main G move-last-line

But this seems worse than falling through to generic bindings when
view-specific ones are unbound.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#483 (comment)

Jonas Fonseca

@jonas
Copy link
Owner

jonas commented Aug 7, 2016

@nkouevda After giving it some more thinking the way to fix this would be to introduce an unbind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants