Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected "failed to read filename" error #487

Closed
gcb opened this issue Mar 21, 2016 · 1 comment
Closed

unexpected "failed to read filename" error #487

gcb opened this issue Mar 21, 2016 · 1 comment

Comments

@gcb
Copy link

gcb commented Mar 21, 2016

If you have the (sane) option to hide diff filename prefixes, tig will fail to find the filename for things like blame functionality.

How to reproduce:

  1. set these settings
diff.mnemonicprefix=false
diff.prefix=false
diff.noprefix=true
  1. open tig, open any commit, try to see a blame (b key default)

offending code is at https://github.com/jonas/tig/blob/master/src/diff.c#L469

here is how a diff looks like with those options, it hides the fake a/ and b/ path.

-- src/file.c
++ src/file.c
@jonas
Copy link
Owner

jonas commented Mar 30, 2016

Looks like tig needs to learn to ignore prefixes. The main challenge will be to figure out which prefix to ignore, e.g. if one had diff.noprefix=true but not the other prefix options disabled.

@jonas jonas closed this as completed in bf1dea7 Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants