Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date disappears if main-view-date-format string is too long #522

Closed
alexch opened this issue Sep 2, 2016 · 1 comment
Closed

date disappears if main-view-date-format string is too long #522

alexch opened this issue Sep 2, 2016 · 1 comment
Labels
Milestone

Comments

@alexch
Copy link

alexch commented Sep 2, 2016

My original goal was to add the time zone to the date column, like this (in ~/.tigrc):

set main-view-date = custom
set main-view-date-local = true
set main-view-date-format = "%F %R %Z"

but that made the entire column disappear. On further investigation, it seems that if the main-view-date-format result string is longer than 16 characters, the whole result is empty and the column shrinks. e.g. these all display fine:

set main-view-date-format = "%R %Z"

set main-view-date-format = "%F %R"

set main-view-date-format = "%Z %Z %Z"

This happens regardless of the main-view-date-width value.


...and I think I just found another bug - - if set main-view-date-local = false then zoned times inside the commit log are not shifted to UTC, but the zone is displayed as UTC:

e.g. a commit date of

Wed Aug 31 09:03:00 2016 -0700

is displayed as

09:03 UTC

but it should be either

16:03 UTC

or

09:03 PDT

I'd be happy to file a separate issue for that if you like.

@jonas
Copy link
Owner

jonas commented Jul 15, 2017

Thanks for the detailed report. The first issue is trivial to fix, however the time zone formatting is a bit harder. I've only managed to fix it so that time zone offsets can be shown. I think this is in line with how Git displays date, since Git only stores time zone offsets in the commit dates.

@jonas jonas added this to the tig-2.3 milestone Jul 15, 2017
@jonas jonas closed this as completed in 1998ef4 Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants