Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] [breaks brew]: configure script is not setting CPPFLAGS despite detecting the presence of ncurses #856

Closed
timotheecour opened this issue Jul 26, 2018 · 1 comment
Closed

[regression] [breaks brew]: configure script is not setting CPPFLAGS despite detecting the presence of ncurses #856

timotheecour opened this issue Jul 26, 2018 · 1 comment

Comments

@timotheecour
Copy link

brew install tig is now broken, and looks like an upstream (tig) issue, see https://github.com/Linuxbrew/homebrew-core/issues/8440#issuecomment-408164091 for context
@jonas
Copy link
Owner

jonas commented Jul 27, 2018 •
edited
Loading

I took a quick look, it seems that the problem is that CURSES_CFLAGS is not used. Currently config.make.in contains:

CC = @CC@
CFLAGS = @CFLAGS@ @COVERAGE_CFLAGS@
CPPFLAGS = @CPPFLAGS@ -DHAVE_CONFIG_H
LDFLAGS = @LDFLAGS@
LDLIBS = @LIBS@ @CURSES_LIBS@

Thus CURSES_LIBS is added to LDLIBS, but we need to add CURSES_CFLAGS to CFLAGS CPPFLAGS.

jonas added a commit that referenced this issue Jul 27, 2018
@jonas
Fix #856: Add CURSES_CFLAGS to CPPFLAGS
305e7ba 
According to `tools/ax_with_curses.m4` `CURSES_CPPFLAGS` was renamed to
`CURSES_CFLAGS` for compatibility with `pkg-config`, so add the flags to
`CPPFLAGS`.

References Linuxbrew/homebrew-core#8440
@jonas jonas closed this as completed in 62d559a Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas @timotheecour