Feature request: separate editor for git actions (blocking) vs files (non-blocking editor)

[avivey]

(This might be a little niche...)

It might make sense to allow different EDITOR selection for "edit file" action then for "edit commit message" action.
My reasoning here is that "edit commit" (and probably all of git actions that require editor) is a blocking action - git waits for the editing to complete before continuing. "Edit a file", OTOH, might be a long operation - open the file in my IDE in a separate window, and continue whatever it was I was doing in tig in this terminal - like maybe open a couple more files from the same diff.

(In my case, I use Notepad++ for "long edits" and Nano for "short" ones, because it's hard to setup N++ to "blocking" mode).

[yegorich]

@avivey how have you setup tig to open files at line in N++? The command line parameter differ in VIM and N++.

[avivey]

@yegorich I disabled opt_editor_line_number, but it's easy to write a wrapper for N++ that can handle that.

[yegorich]

@avivey thanks.

[MartyLake]

Bumping this as I come across the same requirement.

Right now, I have a blocking vim editor for git, as it has to be blocking. Then when I want to talk to git ("which part of this big file was modified recently?"), I get to this part answer using tig, then I memorize the file and line number, and then I navigate to it using nvim-qt.

I wish I could skip the memorize+navigate step, for example binding "e" to a non-blocking nvim-qt, and leave the other git operations (git commit for example) to a blocking simple vim.

EDIT: I will try to bind non blocking edit to tig, and realize my git operations outside of tig using the terminal to see how it feels.

[koutcher]

Adding a TIG_EDITOR variable wouldn't be complicated. I almost forgot about it but I made an attempt when the issue was created. Try koutcher@127cbf7.

[avivey]

Hi @koutcher, you may be thinking about a different ticket - I don't see how $TIG_EDITOR solves this request.

[avivey]

@koutcher: Ok, thinking about it some more, it makes sense:

When invoking git actions, tig doesn't control the editor - git does, so it would ignore TIG_EDITOR and run $GIT_EDITOR or whatever.
Tig's open_editor() is only applicable for editing files (?), so if I set TIG_EDITOR to non-blocking, it will only effect files editing.

Neat.

[MartyLake]

I would love to try koutcher’s patch, but I don’t know how to build for win32.

I have tried to install gnu32 make + deps and gnu32 automake, add the bin directories to the path, and run "make configure", without success. I have cryptic errors like

C:/dev/gnu-make/bin/make.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

Ok, the deps are not shipped with gnu32. after installing https://sourceforge.net/projects/gnuwin32/files/make/3.81/make-3.81-dep.zip/download?use_mirror=kumisystems&download= , I get the following errors

$ make configure
Fichier introuvable - *-test
Fichier introuvable - *-test
Fichier introuvable - *-test
Fichier introuvable - *-test
       GEN  configure
Can't locate Automake/Config.pm in @INC (you may need to install the Automake::Config module) (@INC contains: c /progra~1/AutoMake/share/automake-1.9 /usr/lib/perl5/site_perl /usr/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at /c/dev/gnu-automake/bin/aclocal line 36.
BEGIN failed--compilation aborted at /c/dev/gnu-automake/bin/aclocal line 36.
make: *** [configure] Erreur 2

[krobelus]

Automake doesn't really support windows. Can you use WSL?
Otherwise maybe use Cygwin, with something like this:

choco install cygwin
choco install--source=cygwin git gcc-core make automake pkg-config libiconv-devel libncurses-devel
$Env:PKG_CONFIG_PATH = "C:\tools\cygwin\lib\pkgconfig"
$Env:PATH = "C:\tools\cygwin\bin;" + $Env:PATH
git -c core.autocrlf=false -c core.eol=lf clone https://github.com/jonas/tig
cd tig
make configure
sh configure
make

[MartyLake]

Thanks @krobelus ! Have compiled with Cygwin, added the Cygwin bin to my path, and it just works great ! Thanks !

[blayz3r]

@MartyLake How did you set up your TIG_EDITOR?

[MartyLake]

@blayz3r I have it setup like this in my bashrc

if [[ "$OSTYPE" = "msys" ]];then
  # win32
  export TIG_EDITOR="gvim.bat --remote"
  export LESSEDIT="gvim.bat --remote"
  export VISUAL="gvim.bat --nofork"
  export EDITOR="$VISUAL"
fi

when I hit e to edit a file, it calls gvim --remote so it is non blocking for tig ! on the other hand, I have the --nofork for normal git operations. works like a charm.

[blayz3r]

@MartyLake Thanks that works great!!