Some minor updates for scrolling and for a double-click in diff #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests probably just need fixture changes. |
mckellygit
force-pushed
the
scroll_updates
branch
3 times, most recently
from
dae9d56 to
0f616c0
Compare
mckellygit
force-pushed
the
scroll_updates
branch
from
0f616c0 to
7add3dd
Compare
koutcher
force-pushed
the
scroll_updates
branch
from
4ca443d to
539a63c
Compare
koutcher
force-pushed
the
scroll_updates
branch
from
539a63c to
0a98528
Compare
|
@koutcher looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR was in: #1039
I just moved my repo and re-submitted PR.
This change basically keeps cursorline at same position when scrolling, which I think behaves more similar to most other editors.