-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscroll in pager #1223
Autoscroll in pager #1223
Conversation
@koutcher ping. I've worked on the patch and took all suggestions into account. I wonder what chances have this PR to merge? |
@koutcher ping :) |
@@ -652,11 +653,19 @@ update_view(struct view *view) | |||
return false; | |||
} | |||
|
|||
if ((view->pos.offset + view->height + 1) == view->lines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoscroll seems like an interesting feature. I don't use the pager view but I can imagine autoscroll being useful.
I think this commit should be submitted in a separate PR, without the highlighting changes.
There seems to be an off-by-one error. When I type :!git log
it only scrolls until the last-but-one line; the last line is not visible.
Instead of an option, we could also implement less's F command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krobelus: I've updated the PR to cover only autoscroll feature and fixed the off by 1 error. I agree that autoscroll is useful, I'm using it all the time.
a92e5cb
to
ff9243c
Compare
ff9243c
to
cdd8baa
Compare
Autoscroll the pager view if a new option `pager-autoscroll` is set to `on`. [tk: tweaked the code and added doc]
Thanks. It needed a bit of rework to have things done at the proper place. |
Thanks for merging :) |
A second attempt (after #1139) to add two features:
In this attempt I've did what has been recommended to me previously:
tig
resemblesless
(set pager-autoscroll = off
),,color-pager-regex
.I think that running
make
in pager is a good use case and it could be better supported.