Fix incorrect filename coloring in tig status
#1326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks for the proposition. I think I'd rather revert the changes in draw_filename() as they were made only to match changes draw_filesize() where they were needed to skip the display of size for submodules. |
xaizek
force-pushed
the
fix-filename-colors-in-status
branch
from
74f534f to
aecf5e0
Compare
Due to the way commit a37ce5c updated src/draw.c:draw_filename() the whole line in `tig status` got colored according to `stat-*` which are supposed to color only status markers. This reverts part of that commit which was done for consistency with the changes made to draw_filesize().
xaizek
force-pushed
the
fix-filename-colors-in-status
branch
from
aecf5e0 to
9aa3c6e
Compare
koutcher
pushed a commit
that referenced
this pull request
Apr 11, 2024
Due to the way commit a37ce5c updated src/draw.c:draw_filename() the whole line in `tig status` got colored according to `stat-*` which are supposed to color only status markers. This reverts part of that commit which was done for consistency with the changes made to draw_filesize(). [tk: also revert and rework draw_file_size() for consistency and add comments.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way commit a37ce5c updated src/draw.c:draw_filename() the whole line in
tig statusgot colored according tostat-*which supposed to color only status markers.I don't see other such adhoc conditionals in the file, so there is probably a better way of doing it, but I thought this demonstrates the issue and the approximate way of addressing it.