Update ax_with_curses.m4 to support pkg-config #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ax_with_curses.m4 to latest version and use pkg-config as primary detection mechanism for ncurses. Latest version of ax_with_curses.m4 supports pkg-config. This is important as libcurses is split into libcurses.so and libtinfo.so on many distros and linking against libcurses.so is not sufficiant. Pkg-config allows proper detection of necessary libs. Signed-off-by: Justin Lecher <jlec@gentoo.org>
jonas
reviewed
Nov 26, 2016
| AC_MSG_WARN([This means that tig will not correctly render UTF-8.]) | ||
| esac | ||
| AC_SUBST(CURSES_LIB) | ||
| PKG_CHECK_MODULES([CURSES], [ncursesw], |
There was a problem hiding this comment.
I ended up reverting this change because the AX_WITH_CURSES macro will call pkg-config automatically.
|
Great, thanks @jlec. Hope this still works on Gentoo with the changes I made |
|
Works perfectly fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of ax_with_curses.m4 supports pkg-config. This is important
as libcurses is split into libcurses.so and libtinfo.so on many distros
and linking against libcurses.so is not sufficiant. Pkg-config allows
proper detection of necessary libs.
Signed-off-by: Justin Lecher jlec@gentoo.org