performance: throttle titlebar screen updates during loading #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* blame: every 5 percent * line-oriented: every 100 lines
rolandwalker
force-pushed
the
perf-throttle-load-updates
branch
from
0e074e1 to
3eab805
Compare
jonas
reviewed
Jun 28, 2017
| @@ -665,7 +665,10 @@ update_view_title(struct view *view) | |||
| wprintw(window, " - %s %d of %zd", | |||
| view->ops->type, | |||
| line->lineno, | |||
| view->lines - view->custom_lines); | |||
| MAX(line->lineno, | |||
|
Heh, reminds me of the tweet about |
This was referenced Jun 29, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of updating the UI at maximum granularity:
This little optimization turns out to give a fair gain. In a very large repo on SSD, the main view completes 0.4 sec faster for me (8% speedup). Across many small repos I find the gains are always measurable, though almost always less than 0.1 sec. These values will vary by platform, repo and particularly by terminal emulator.
Even though we are still calling
wprintw()repeatedly, ncurses is able to notice when the screen contents do not change, and optimize away unneeded writes.